Make Breakdown limit customizable and Allow empty breakdown value in trends and funnels#5357
Merged
neilkakkar merged 12 commits intomasterfrom Aug 3, 2021
Merged
Make Breakdown limit customizable and Allow empty breakdown value in trends and funnels#5357neilkakkar merged 12 commits intomasterfrom
neilkakkar merged 12 commits intomasterfrom
Conversation
neilkakkar
changed the title
Contributor
Author
|
Labels still broken for Funnels, fixing that |
neilkakkar
commented
Jul 30, 2021
| render: function RenderLabel({}, step: FlattenedFunnelStep): JSX.Element { | ||
| const isBreakdownChild = !!filters.breakdown && !step.isBreakdownParent | ||
| const color = getStepColor(step, !!filters.breakdown) | ||
| console.log(step) |
alexkim205
approved these changes
Jul 30, 2021
EDsCODE
approved these changes
Aug 3, 2021
Collaborator
EDsCODE
left a comment
EDsCODE
left a comment
There was a problem hiding this comment.
backend changes look good
| FROM events e | ||
| WHERE | ||
| team_id = %(team_id)s {entity_query} {parsed_date_from} {parsed_date_to} {prop_filters} | ||
| AND JSONHas(properties, %(key)s) |
Collaborator
There was a problem hiding this comment.
Oh, was this what was preventing none results from returning? I think that may have led me to implement the workaround for unioning the events with no property
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Adds a customizable limit to the number of breakdown values. Resolves #5341
Also does the same for trends, and changes how
nonebreakdown used to work: Now, none isn't returned if it's empty, and is treated just like any other breakdown value (so works with limit/offset as well)For the frontend: Since now
''is a valid breakdown value, I update the labels to work with this (and added tests for this)Checklist