Skip to content

Resolve caching issues with persons breakdown#5292

Merged
neilkakkar merged 1 commit intomasterfrom
cachebreakdwonfix
Jul 22, 2021
Merged

Resolve caching issues with persons breakdown#5292
neilkakkar merged 1 commit intomasterfrom
cachebreakdwonfix

Conversation

@neilkakkar
Copy link
Copy Markdown
Contributor

@neilkakkar neilkakkar commented Jul 22, 2021

Changes

Mixins with the same to_dict name aren't registered via inspect :/

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests
  • Migrations are safe to run at scale (e.g. PostHog Cloud) – present proof if not obvious
  • New/changed UI is decent on smartphones (viewport width around 360px)

@neilkakkar neilkakkar requested review from EDsCODE and liyiy July 22, 2021 17:15
@timgl timgl temporarily deployed to posthog-pr-5292 July 22, 2021 17:17 Inactive
@neilkakkar neilkakkar enabled auto-merge (squash) July 22, 2021 17:22
EDsCODE
EDsCODE approved these changes Jul 22, 2021
View reviewed changes
Copy link
Copy Markdown
Collaborator

@EDsCODE EDsCODE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good find

@neilkakkar neilkakkar merged commit 9090918 into master Jul 22, 2021
@neilkakkar neilkakkar deleted the cachebreakdwonfix branch July 22, 2021 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EDsCODE EDsCODE EDsCODE approved these changes

@liyiy liyiy Awaiting requested review from liyiy

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@neilkakkar @EDsCODE @timgl