Skip to content

Funnel steps conversion time per step#4892

Merged
EDsCODE merged 2 commits intomasterfrom
funnel_step_average_conversion_time
Jun 29, 2021
Merged

Funnel steps conversion time per step#4892
EDsCODE merged 2 commits intomasterfrom
funnel_step_average_conversion_time

Conversation

@EDsCODE
Copy link
Copy Markdown
Collaborator

@EDsCODE EDsCODE commented Jun 29, 2021

Changes

Please describe.

  • change the step query result shape. Remove the last group by so that the average can be performed over entire list of results
  • remove "people" check in funnel related queries as this will become deprecated in favor of a separate api call to retrieve funnel people
    If this affects the frontend, include screenshots.

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests
  • Migrations are safe to run at scale (e.g. PostHog Cloud) – present proof if not obvious
  • Frontend/CSS is usable at 320px (iPhone SE) and decent at 360px (most phones)
  • Breaking changes are backwards-compatible. Ensure old/new frontend requests work with new/old backends, and vice versa.

@EDsCODE EDsCODE requested review from Twixes and neilkakkar June 29, 2021 03:41
@timgl timgl temporarily deployed to posthog-pr-4892 June 29, 2021 03:42 Inactive
Copy link
Copy Markdown
Contributor

@neilkakkar neilkakkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's one mypy error.

To come next: No commas before queries, testing persons in step queries along with count.

Rest looks good 👍

@EDsCODE EDsCODE temporarily deployed to posthog-pr-4892 June 29, 2021 14:51 Inactive
@EDsCODE EDsCODE merged commit ebea9ab into master Jun 29, 2021
@EDsCODE EDsCODE deleted the funnel_step_average_conversion_time branch June 29, 2021 15:16
@Twixes Twixes mentioned this pull request Jun 30, 2021
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants