Conversation
…t for conversion window;
… cleanup via destroy() method
…ed funnel_persons and funnel_trends_persons into individual classes;
…com:PostHog/posthog into funnel-persons-pagination-conversion-window
* dedup + tests * deep equality. Tests to come * write test for entity equality * finish testing funnels * clean up comments
Collaborator
|
should merge in master to reduce the noise here |
EDsCODE
approved these changes
Jul 1, 2021
Collaborator
EDsCODE
left a comment
EDsCODE
left a comment
There was a problem hiding this comment.
added persons handling and adjusted query result format to handle step times
Contributor
Author
|
Nice, thank you! :) I was going to do this as a separate PR since doing it too early creates lots of dependency annoyance, but this order was just right, much appreciated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
I'm thinking if it's worth going this route or refactoring these flags to be class variables. For now, this seems fine to me. Perhaps worth revisiting if our number of flags start exploding.
Will go in after #4868
Checklist