Merged
Conversation
…t for conversion window;
… cleanup via destroy() method
…ed funnel_persons and funnel_trends_persons into individual classes;
…com:PostHog/posthog into funnel-persons-pagination-conversion-window
neilkakkar
reviewed
Jun 29, 2021
neilkakkar
reviewed
Jun 29, 2021
neilkakkar
reviewed
Jun 29, 2021
neilkakkar
reviewed
Jun 29, 2021
neilkakkar
reviewed
Jun 29, 2021
|
|
||
|
|
||
| class ClickhouseFunnelPersons(ClickhouseFunnelBase): | ||
| def get_query(self, format_properties): |
Contributor
There was a problem hiding this comment.
Small refactoring note for the future (not necessary for now, but for when we move FunnelNew->Funnel):
It seems to me like format_properties are not generic enough anymore to warrant a place in the basic get_query signature? maybe it's worth every query generating its own properties that it needs.
For example, here it's a bit confusing that offset is missing, but turns out it comes from format_properties, and is literally equal to self._filters.offset - which seems to be the only thing being used
neilkakkar
reviewed
Jun 29, 2021
neilkakkar
reviewed
Jun 29, 2021
7 tasks
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Please describe.
funnel_stepparameter that specifies the step at which you want the list of persons. Indexing starts at 1 so 1 = first step, 2 = second step, etc. The dropoffs are denoted by negatives so the people that dropped off from the first to second step would be -2, dropoffs from second to third step would be -3, etc.If this affects the frontend, include screenshots.
Checklist