Conversation
…t for conversion window;
… cleanup via destroy() method
…ed funnel_persons and funnel_trends_persons into individual classes;
…com:PostHog/posthog into funnel-persons-pagination-conversion-window
neilkakkar
reviewed
Jun 23, 2021
| SELECT | ||
| person_id, | ||
| timestamp, | ||
| {self.get_partition_cols(1, max_steps)} |
Contributor
There was a problem hiding this comment.
If I understand correctly
{self.get_partition_cols(level_index - 1, max_steps)}
Edit: Ah, no, my bad, it's the innermost one, so 1 is right.
Contributor
There was a problem hiding this comment.
step_i seems to be 0 indexed, while level_index seems to be 1 indexed? I think easier if both follow the same?
Base automatically changed from
funnel-persons-pagination-conversion-window
to
master
June 24, 2021 01:49
* dedup + tests * deep equality. Tests to come * write test for entity equality * finish testing funnels * clean up comments
7 tasks
neilkakkar
approved these changes
Jun 28, 2021
Contributor
neilkakkar
left a comment
neilkakkar
left a comment
There was a problem hiding this comment.
Think this is good enough for now!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Please describe.
If this affects the frontend, include screenshots.
Checklist