Funnels reorganization, persons pagination, and conversion window support#4810
Merged
buwilliams merged 15 commits intomasterfrom Jun 24, 2021
Merged
Funnels reorganization, persons pagination, and conversion window support#4810buwilliams merged 15 commits intomasterfrom
buwilliams merged 15 commits intomasterfrom
Conversation
… cleanup via destroy() method
EDsCODE
requested changes
Jun 21, 2021
Collaborator
EDsCODE
left a comment
EDsCODE
left a comment
There was a problem hiding this comment.
Comment below + backend tests. Otherwise looks good
…ed funnel_persons and funnel_trends_persons into individual classes;
Twixes
reviewed
Jun 22, 2021
…com:PostHog/posthog into funnel-persons-pagination-conversion-window
EDsCODE
reviewed
Jun 23, 2021
neilkakkar
reviewed
Jun 23, 2021
| # See migration 0121 | ||
|
|
||
| @staticmethod | ||
| def get_distinct_ids_and_email_by_ids(person_ids, team_id): |
Contributor
There was a problem hiding this comment.
This seems to be the opposite of what it should be?
I.e., bulk querying uses the bulk API (which gains the advantage of querying in bulk), while the single query makes a call to the bulk end point with a list of one item.
https://docs.djangoproject.com/en/3.2/ref/models/querysets/#in-bulk - in_bulk achieves this, I think.
Contributor
Author
There was a problem hiding this comment.
This was a quick pass but I'll be refactoring with ejecting to SQL for best performance. Just trying to get it out the door quickly.
neilkakkar
reviewed
Jun 23, 2021
buwilliams
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
GenerateLocalclass to generate data for local developmentmicroseconds_from_daysto convert days to microsecondsconversion windowfor funnelsGenerateLocal Usage
Open django shell with Clickhouse environment variables
You can also cleanup the data with but you'll need to drop the Clickhouse db manually.