Update wording for runEvery functions in PluginEditor#4315
Merged
neilkakkar merged 2 commits intomasterfrom May 12, 2021
Merged
Update wording for runEvery functions in PluginEditor#4315neilkakkar merged 2 commits intomasterfrom
runEvery functions in PluginEditor#4315neilkakkar merged 2 commits intomasterfrom
Conversation
There's a distributed lock across plugin servers that ensures only one server gets the task ( https://github.com/PostHog/plugin-server/blob/master/src/main/services/schedule.ts#L43 ), and piscina enqueues the task only once, which ensures only one worker in a server gets it (https://github.com/PostHog/plugin-server/blob/master/src/main/services/schedule.ts#L94-L103)
Contributor
|
Good spot! I went in to make "instance" plural, but ended up making a few other copy edits. See what you think and feel free to disagree. I think we don't need to worry the user with stuff about how our workers are set up, let's just tell them it will run once and that should be fine. |
yakkomajuri
approved these changes
May 12, 2021
Contributor
Author
|
ha, even better! I'm guessing there's something weird going on with the Cypress tests? Flaky? |
Contributor
|
It's a constant battle with Cypress - feel free to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a distributed lock across plugin servers that ensures only one server gets the task ( https://github.com/PostHog/plugin-server/blob/master/src/main/services/schedule.ts#L43 ), and piscina enqueues the task only once, which ensures only one worker in a server gets it (https://github.com/PostHog/plugin-server/blob/master/src/main/services/schedule.ts#L94-L103)
Checklist