fix(dashboards): copy filters, variables, breakdown_colors, and data_color_theme_id when duplicating dashboards #42898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmiska25
commented
Dec 6, 2025
dmiska25
force-pushed
the
fix/dashboard-filter-duplication
branch
from
9140336 to
a62a07f
Compare
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds functionality to copy dashboard filters when duplicating a dashboard, addressing the inconvenience of manually setting many filters on a duplicate. The implementation fetches filters from the source dashboard unless explicitly overridden in the request.
Key Changes:
- Modified dashboard duplication logic to copy filters from the source dashboard by default
- Added conditional logic to allow explicit filter override when provided in the request
- Refactored
existing_dashboardfetching to occur earlier in the create flow for reuse
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| posthog/api/dashboards/dashboard.py | Implements filter copying logic by fetching the source dashboard earlier and copying its filters when duplicating, unless explicit filters are provided in the request |
| posthog/api/test/dashboards/test_dashboard.py | Adds two test cases to verify filters are copied during duplication and that explicit filters override source filters |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vdekrijger
reviewed
Dec 12, 2025
vdekrijger
reviewed
Dec 12, 2025
dmiska25
added a commit
to dmiska25/posthog
that referenced
this pull request
Dec 13, 2025
dmiska25
added a commit
to dmiska25/posthog
that referenced
this pull request
Dec 13, 2025
…wn_colors, and data_color_theme_id during dashboard duplication
dmiska25
force-pushed
the
fix/dashboard-filter-duplication
branch
from
a62a07f to
c93161b
Compare
dmiska25
changed the title
Contributor
|
Would you also please be able to fix the linter errors 🙏 ? Additionally, I think that merging master will help resolve some of the failing CI jobs as from a few spotchecks they did not appear to be related to your changes! |
dmiska25
force-pushed
the
fix/dashboard-filter-duplication
branch
from
c93161b to
49007e8
Compare
dmiska25
added a commit
to dmiska25/posthog
that referenced
this pull request
Dec 15, 2025
dmiska25
added a commit
to dmiska25/posthog
that referenced
this pull request
Dec 15, 2025
…wn_colors, and data_color_theme_id during dashboard duplication
…wn_colors, and data_color_theme_id during dashboard duplication
dmiska25
force-pushed
the
fix/dashboard-filter-duplication
branch
from
49007e8 to
8da2e81
Compare
vdekrijger
approved these changes
Dec 18, 2025
Contributor
vdekrijger
left a comment
vdekrijger
left a comment
There was a problem hiding this comment.
Thanks for fixing this!
odin-posthog
pushed a commit
that referenced
this pull request
Dec 18, 2025
…color_theme_id when duplicating dashboards (#42898)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, when duplicating dashboards, filter selections and other configuration settings are not included. This is inconvenient if there are many filters and the duplicate dashboard only needs a few changes.
Changes
Added logic to duplicate dashboard filters, variables, breakdown_colors, and data_color_theme_id along with the dashboard unless those values were included with the request. If explicit values are provided in the request, they override the source dashboard values.
Also refactored existing_dashboard variable initialization for clarity per PR feedback.
How did you test this code?
Added 9 automated tests to ensure all fields are copied correctly from the existing dashboard record to the duplicate, and that explicit values override source values. Also, ran all existing automated tests with no regressions.