-
Notifications
You must be signed in to change notification settings - Fork 140
Update PoseLib version to 2.0.5 with comprehensive changelog #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@pablospe 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs. I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review. |
Co-authored-by: pablospe <[email protected]>
|
Perhaps the changelog in README.md should be updated as well. I am not sure what has changed exactly since the 2.0.4 release. Perhaps @copilot can figure it out? |
Co-authored-by: vlarsson <[email protected]>
Updated the changelog in README.md for version 2.0.5. Since this is primarily a version bump to ensure correct wheel tagging following the Python packaging improvements from PR #146, the changelog entry reflects that focus. Commit: Update changelog for version 2.0.5 |
Co-authored-by: vlarsson <[email protected]>
Added comprehensive changelog for version 2.0.5 including all the features and bugfixes from the PRs you mentioned. The changelog now covers: • New features: homography decomposition (#121), FULL_OPENCV camera model (#138), initial model passing to robust solvers (#136), non-upright gravity relative pose (#124) Commit: d432c1f |
vlarsson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Unfamiliar with how copilot runs in github. Do I just "@"? If so, @copilot could you add a commit to this PR fixing the above review issues? |
|
Github has a tool for this, see next image: If you go to: https://github.com/PoseLib/PoseLib/releases/new Here the notes: ## What's Changed
* Add Conan install section in README by @uilianries in https://github.com/PoseLib/PoseLib/pull/106
* Add some badges to README.md. by @pablospe in https://github.com/PoseLib/PoseLib/pull/107
* Move objects to avoid copy in camera constructors by @ahojnnes in https://github.com/PoseLib/PoseLib/pull/114
* Change default -march=native to be disabled by @vlarsson in https://github.com/PoseLib/PoseLib/pull/115
* Refined P3P solver, and a new implementation for rel_pose_upright_3pt by @yaqding in https://github.com/PoseLib/PoseLib/pull/93
* Bugfix in default camera for shared focal relpose by @kocurvik in https://github.com/PoseLib/PoseLib/pull/120
* Add numpy as a dependency for the python wheel by @theartful in https://github.com/PoseLib/PoseLib/pull/125
* Fix pybind11 calling overhead by @vlarsson in https://github.com/PoseLib/PoseLib/pull/116
* Wrapper for relative pose with non-upright gravity by @B1ueber2y in https://github.com/PoseLib/PoseLib/pull/124
* Add overloaded wrapper methods for passing poselib::Camera instead of py::dict. by @ghanning in https://github.com/PoseLib/PoseLib/pull/127
* Added H decomposition by @kocurvik in https://github.com/PoseLib/PoseLib/pull/121
* Release the GIL whenever possible to allow multithreading from python by @theartful in https://github.com/PoseLib/PoseLib/pull/123
* Pybind reference fixes by @ghanning in https://github.com/PoseLib/PoseLib/pull/128
* Restore default arguments for `ransac_opt` and `bundle_opt` by @ghanning in https://github.com/PoseLib/PoseLib/pull/135
* Add option to pass initial model to robust solvers. by @ghanning in https://github.com/PoseLib/PoseLib/pull/136
* Added `FULL_OPENCV` camera model from `dev` by @VladislavZavadskyy in https://github.com/PoseLib/PoseLib/pull/138
* faster up1p2pl solver by @yaqding in https://github.com/PoseLib/PoseLib/pull/139
* New homography solver by @yaqding in https://github.com/PoseLib/PoseLib/pull/141
* Scale cauchy loss to approximate r^2 in inlier region by @theartful in https://github.com/PoseLib/PoseLib/pull/143
* Remove gcc flags when using msvc for building pyposelib by @theartful in https://github.com/PoseLib/PoseLib/pull/132
* Symmetric homography transfer error in local optimization by @yaqding in https://github.com/PoseLib/PoseLib/pull/144
* Updated Python packaging + CI by @Parskatt in https://github.com/PoseLib/PoseLib/pull/146
## New Contributors
* @uilianries made their first contribution in https://github.com/PoseLib/PoseLib/pull/106
* @yaqding made their first contribution in https://github.com/PoseLib/PoseLib/pull/93
* @theartful made their first contribution in https://github.com/PoseLib/PoseLib/pull/125
* @ghanning made their first contribution in https://github.com/PoseLib/PoseLib/pull/127
* @VladislavZavadskyy made their first contribution in https://github.com/PoseLib/PoseLib/pull/138
* @Parskatt made their first contribution in https://github.com/PoseLib/PoseLib/pull/146
**Full Changelog**: https://github.com/PoseLib/PoseLib/compare/v2.0.4...v2.0.5 |
|
I fixed the README now. Should I merge it? |
|
@Parskatt To merge it you need to approve it because now it is blocked. Notice the release is already done: |
Parskatt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@pablospe sorry for the late response, looks good now. |

This PR bumps the PoseLib version from 2.0.4 to 2.0.5 and provides a comprehensive changelog documenting all the features and bugfixes included in this release.
The version has been updated in the key locations that control version propagation throughout the build system:
setup.pyline 85:version="2.0.5"CMakeLists.txtline 3:project(PoseLib VERSION 2.0.5)The changelog in
README.mdnow includes all significant changes since version 2.0.4:New Features:
FULL_OPENCVcamera model fromdev#138)Performance Improvements:
Python Enhancements:
Bug Fixes:
Build System:
With these changes, the CI system will build wheels tagged with version 2.0.5 and users will have a complete overview of all improvements in this release.
Fixes #148.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.