Avoid unnecessary heap allocation and copy#181
Merged
PolyMeilex merged 1 commit intoPolyMeilex:masterfrom Feb 24, 2024
ryco117:master
Merged
Avoid unnecessary heap allocation and copy#181PolyMeilex merged 1 commit intoPolyMeilex:masterfrom ryco117:master
PolyMeilex merged 1 commit intoPolyMeilex:masterfrom
ryco117:master
Conversation
Contributor
Author
|
The error says that the changelog check can be avoided by adding the |
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like the current implementation of
From<FileHandle> for PathBufpasses aPathreference to thePathBuf::fromwhich results in a new heap allocation from a call toto_os_string()down the call-stack.Since
From<FileHandle>consumes theFileHandleit seems reasonable to consume the memberPathBufand return it to the caller without any copies or allocations.