Skip to content

[AIRFLOW-3971] Add Google Cloud Natural Language#74

Closed
mik-laj wants to merge 10 commits intomasterfrom
feature/gcp-natural-lanaguage-operators
Closed

[AIRFLOW-3971] Add Google Cloud Natural Language#74
mik-laj wants to merge 10 commits intomasterfrom
feature/gcp-natural-lanaguage-operators

Conversation

@mik-laj
Copy link
Copy Markdown
Member

@mik-laj mik-laj commented Feb 27, 2019

.

@potiuk potiuk added the feature label Mar 2, 2019
@mik-laj mik-laj force-pushed the feature/gcp-natural-lanaguage-operators branch 6 times, most recently from d48db2a to 041955a Compare March 11, 2019 14:20
@mik-laj mik-laj changed the title [AIRFLOW-YYY]Add Google Cloud Natural Language [AIRFLOW-3971] Add Google Cloud Natural Language Mar 11, 2019
Comment thread airflow/contrib/hooks/gcp_api_base_hook.py Outdated
@mik-laj mik-laj force-pushed the feature/gcp-natural-lanaguage-operators branch 4 times, most recently from 1ff23ed to 76d1ab3 Compare March 12, 2019 10:25
Copy link
Copy Markdown

@antonimaciej antonimaciej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would consider putting documentation "partials" feature in a separate PR, but that's just a thought.
Great work overall!

Comment thread airflow/contrib/hooks/gcp_natural_language_hook.py Outdated
Comment thread airflow/contrib/hooks/gcp_natural_language_hook.py Outdated
Comment thread airflow/contrib/hooks/gcp_natural_language_hook.py Outdated
Comment thread docs/exts/docroles.py Outdated
Comment thread airflow/contrib/example_dags/example_gcp_natural_language.py Outdated
Comment thread docs/exts/docroles.py Outdated
@mik-laj mik-laj force-pushed the feature/gcp-natural-lanaguage-operators branch 8 times, most recently from 7d4f7ca to 447de8a Compare April 1, 2019 22:12
ashb and others added 2 commits April 3, 2019 15:38
Sendgrid just released 6.0 with breaking changes, and I don't have the
time to define how to change our code or tests - as they haven't
published a migration guide :(
@mik-laj mik-laj force-pushed the feature/gcp-natural-lanaguage-operators branch 6 times, most recently from 37db3a8 to 0e1f0d6 Compare April 4, 2019 21:26
@mik-laj mik-laj force-pushed the feature/gcp-natural-lanaguage-operators branch 2 times, most recently from 81b9ce2 to d04c780 Compare April 5, 2019 09:55
@codecov-io
Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@5c17948). Click here to learn what that means.
The diff coverage is 82.92%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #74   +/-   ##
=========================================
  Coverage          ?   76.24%           
=========================================
  Files             ?      469           
  Lines             ?    30222           
  Branches          ?        0           
=========================================
  Hits              ?    23042           
  Misses            ?     7180           
  Partials          ?        0
Impacted Files Coverage Δ
airflow/configuration.py 92.12% <ø> (ø)
...low/contrib/operators/wasb_delete_blob_operator.py 100% <ø> (ø)
airflow/www/utils.py 82.7% <ø> (ø)
airflow/utils/helpers.py 82.51% <ø> (ø)
airflow/operators/hive_to_druid.py 63.07% <ø> (ø)
airflow/contrib/sensors/wasb_sensor.py 100% <ø> (ø)
airflow/contrib/kubernetes/pod.py 100% <ø> (ø)
airflow/contrib/operators/qubole_check_operator.py 71.76% <ø> (ø)
airflow/contrib/hooks/gcp_api_base_hook.py 84.76% <ø> (ø)
airflow/contrib/operators/file_to_wasb.py 100% <ø> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c17948...d04c780. Read the comment docs.

@mik-laj mik-laj closed this Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants