Skip to content

Update dependencies#390

Merged
Palbolsky merged 10 commits intodevelopfrom
update-dependencies
Oct 18, 2024
Merged

Update dependencies#390
Palbolsky merged 10 commits intodevelopfrom
update-dependencies

Conversation

@Palbolsky
Copy link
Copy Markdown
Collaborator

@Palbolsky Palbolsky commented Sep 19, 2024

Description

This PR updates the application's dependencies.
Some dependencies could not be updated (or could not be updated to the latest version) for the following reasons:

  • @vercel/webpack-asset-relocator-loader: the latest version of @vercel/webpack-asset-relocator-loader is not compatible with electron-forge ;
  • eslint: not updated at latest version because eslint-plugin-react-hooks is not compatible with the latest version of eslint ;
  • styled-components: creates styling problems in the application (scrollbar, problems with hovers, some "buttons" missing) ;
  • react-flow-renderer: should be renamed reactflow and migrated to recent versions (risk of breaking the maplink).

The dependency update revealed a few minor bugs that have been fixed:

  • Fix typo in config.ts (entities) ;
  • Fix PRE_MIGRATION_CREATURE_VALIDATOR in linkResourcesToCreatures (textId replaced by formTextId) ;
  • Fix typing in defineEditorOverlay (EditorOverlayV2.tsx).

Changes:

  • The react-i18next update required changes to TFunction imports. The TFunction interface is no longer in react-i18next but only in i18next. The imports have been updated ;
  • Add "@typescript-eslint/no-unused-vars": "warn" in eslint rules ;
  • The log initialisation has been updated because the front and backend logs were getting mixed up.
  • react-beautiful-dnd has been removed and replace by @hello-pangua/dnd. react-beautiful-dnd was not maintained and @hello-pangua/dnd is its successor. Minor changes have been made.

Tested:

  • electron-updater has been updated and it works correctly (v5 to v6 and v6 to v6)

Known issue

Open the devtools shows an error in the main log. This has had no impact on the workflow, but it pollutes the developers' logs. An issue exists on the electron repo, but there is no fix: electron/electron#41614

image

Note before testing

Update npm with the following command: npm install -g [email protected]
Don't forget to npm i to install the new packages
If you encounter problems, delete the node_modules folder.
Warnings can appear: it's not us but the dependencies.

Tests to perform

  • Check that there is no regression in the application

@Palbolsky Palbolsky added the Technical story Issues related to technical work label Sep 19, 2024
@Palbolsky Palbolsky self-assigned this Sep 19, 2024
Copy link
Copy Markdown
Collaborator

@AerunDev AerunDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai fait le tour en détail de toute l'application, et je n'ai rien constaté de problématique d'un point de vue fonctionnel.
Pour faciliter les choses je prendrai un peu de temps à mes prochaines vacances pour mettre à dispo un protocole de test complet, pour qu'on puisse avoir plus de testeurs.

@Palbolsky Palbolsky force-pushed the update-dependencies branch from c1805b3 to 52545f9 Compare October 15, 2024 12:19
@Palbolsky Palbolsky merged commit 35a1af1 into develop Oct 18, 2024
@Palbolsky Palbolsky deleted the update-dependencies branch October 18, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Technical story Issues related to technical work

Projects

Status: Done

3 participants