Conversation
Menthx
approved these changes
Oct 1, 2024
AerunDev
approved these changes
Oct 14, 2024
Collaborator
AerunDev
left a comment
There was a problem hiding this comment.
J'ai fait le tour en détail de toute l'application, et je n'ai rien constaté de problématique d'un point de vue fonctionnel.
Pour faciliter les choses je prendrai un peu de temps à mes prochaines vacances pour mettre à dispo un protocole de test complet, pour qu'on puisse avoir plus de testeurs.
…MNode is deprecated
c1805b3 to
52545f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the application's dependencies.
Some dependencies could not be updated (or could not be updated to the latest version) for the following reasons:
@vercel/webpack-asset-relocator-loader: the latest version of@vercel/webpack-asset-relocator-loaderis not compatible withelectron-forge;eslint: not updated at latest version becauseeslint-plugin-react-hooksis not compatible with the latest version of eslint ;styled-components: creates styling problems in the application (scrollbar, problems with hovers, some "buttons" missing) ;react-flow-renderer: should be renamedreactflowand migrated to recent versions (risk of breaking the maplink).The dependency update revealed a few minor bugs that have been fixed:
config.ts(entities) ;PRE_MIGRATION_CREATURE_VALIDATORinlinkResourcesToCreatures(textIdreplaced byformTextId) ;defineEditorOverlay(EditorOverlayV2.tsx).Changes:
TFunctionimports. TheTFunctioninterface is no longer inreact-i18nextbut only ini18next. The imports have been updated ;"@typescript-eslint/no-unused-vars": "warn"in eslint rules ;react-beautiful-dndhas been removed and replace by@hello-pangua/dnd.react-beautiful-dndwas not maintained and@hello-pangua/dndis its successor. Minor changes have been made.Tested:
electron-updaterhas been updated and it works correctly (v5 to v6 and v6 to v6)Known issue
Open the devtools shows an error in the main log. This has had no impact on the workflow, but it pollutes the developers' logs. An issue exists on the electron repo, but there is no fix: electron/electron#41614
Note before testing
Update
npmwith the following command:npm install -g [email protected]Don't forget to
npm ito install the new packagesIf you encounter problems, delete the
node_modulesfolder.Warnings can appear: it's not us but the dependencies.
Tests to perform