build of 1.14.1 fails with boost 1.86.0 #6157
Description
Describe the bug
1.14.1 (the latest release,according to github) fails to build with boost 1.86.0. Because the nature of packaging systems is to carry one version of each package, it's necessary for every package to have a release that will build with the latest release of all dependencies.
pkgsrc recently got boost 1.86.0, and now the pcl build is failing:
> make
=> Bootstrap dependency digest>=20211023: found digest-20220214
===> Checking for vulnerabilities in pcl-1.14.1nb5
===> Building for pcl-1.14.1nb5
[28/290] Building CXX object visualization/CMakeFiles/pcl_visualization.dir/src/pcl_visualizer.cpp.o
FAILED: visualization/CMakeFiles/pcl_visualization.dir/src/pcl_visualizer.cpp.o
/tmp/work/graphics/pcl/work/.cwrapper/bin/c++ -DPCLAPI_EXPORTS -DQT_CORE_LIB -DQT_DISABLE_DEPRECATED_BEFORE=0x050900 -DQT_GUI_LIB -DQT_NO_DEBUG -DQT_OPENGL_LIB -DQT_WIDGETS_LIB -Dkiss_fft_scalar=double -DvtkRenderingContext2D_AUTOINIT_INCLUDE=\"/tmp/work/graphics/pcl/work/pcl-pcl-1.14.1/cmake-pkgsrc-build/CMakeFiles/vtkModuleAutoInit_e8a719bca0f84dfe780c94feaaba76ea.h\" -DvtkRenderingCore_AUTOINIT_INCLUDE=\"/tmp/work/graphics/pcl/work/pcl-pcl-1.14.1/cmake-pkgsrc-build/CMakeFiles/vtkModuleAutoInit_e8a719bca0f84dfe780c94feaaba76ea.h\" -I/tmp/work/graphics/pcl/work/pcl-pcl-1.14.1/cmake-pkgsrc-build/include -I/tmp/work/graphics/pcl/work/pcl-pcl-1.14.1/common/include -I/tmp/work/graphics/pcl/work/pcl-pcl-1.14.1/io/include -I/tmp/work/graphics/pcl/work/pcl-pcl-1.14.1/kdtree/include -I/tmp/work/graphics/pcl/work/pcl-pcl-1.14.1/geometry/include -I/tmp/work/graphics/pcl/work/pcl-pcl-1.14.1/search/include -I/tmp/work/graphics/pcl/work/pcl-pcl-1.14.1/octree/include -I/tmp/work/graphics/pcl/work/pcl-pcl-1.14.1/openni/include -I/tmp/work/graphics/pcl/work/pcl-pcl-1.14.1/openni2/include -I/tmp/work/graphics/pcl/work/pcl-pcl-1.14.1/ensenso/include -I/tmp/work/graphics/pcl/work/pcl-pcl-1.14.1/davidSDK/include -I/tmp/work/graphics/pcl/work/pcl-pcl-1.14.1/dssdk/include -I/tmp/work/graphics/pcl/work/pcl-pcl-1.14.1/rssdk/include -I/tmp/work/graphics/pcl/work/pcl-pcl-1.14.1/visualization/include -isystem /tmp/work/graphics/pcl/work/pcl-pcl-1.14.1/recognition/include/pcl/recognition/3rdparty -isystem /usr/pkg/include -isystem /tmp/work/graphics/pcl/work/.buildlink/include/eigen3 -isystem /tmp/work/graphics/pcl/work/.buildlink/include/vtk-9.2 -isystem /tmp/work/graphics/pcl/work/.buildlink/include -isystem /tmp/work/graphics/pcl/work/.buildlink/include/freetype2 -isystem /tmp/work/graphics/pcl/work/.buildlink/qt5/include -isystem /tmp/work/graphics/pcl/work/.buildlink/qt5/include/QtOpenGL -isystem /tmp/work/graphics/pcl/work/.buildlink/qt5/include/QtWidgets -isystem /tmp/work/graphics/pcl/work/.buildlink/qt5/include/QtGui -isystem /tmp/work/graphics/pcl/work/.buildlink/qt5/include/QtCore -isystem /tmp/work/graphics/pcl/work/.buildlink/qt5/./mkspecs/netbsd-g++ -O2 -I/usr/pkg/include -I/usr/include -I/usr/X11R7/include -I/usr/X11R7/include/libdrm -I/usr/pkg/include/freetype2 -I/usr/pkg/qt5/include -I/usr/pkg/include/glib-2.0 -I/usr/pkg/include/gio-unix-2.0 -I/usr/pkg/lib/glib-2.0/include -I/usr/pkg/include/harfbuzz -DNDEBUG -std=c++14 -fPIC -fPIC -MD -MT visualization/CMakeFiles/pcl_visualization.dir/src/pcl_visualizer.cpp.o -MF visualization/CMakeFiles/pcl_visualization.dir/src/pcl_visualizer.cpp.o.d -o visualization/CMakeFiles/pcl_visualization.dir/src/pcl_visualizer.cpp.o -c /tmp/work/graphics/pcl/work/pcl-pcl-1.14.1/visualization/src/pcl_visualizer.cpp
/tmp/work/graphics/pcl/work/pcl-pcl-1.14.1/visualization/src/pcl_visualizer.cpp: In member function 'std::string pcl::visualization::PCLVisualizer::getUniqueCameraFile(int, char**)':
/tmp/work/graphics/pcl/work/pcl-pcl-1.14.1/visualization/src/pcl_visualizer.cpp:4595:24: error: cannot convert 'unsigned int [5]' to 'unsigned char (&)[20]'
4595 | sha1.get_digest (digest);
| ^~~~~~
| |
| unsigned int [5]
In file included from /tmp/work/graphics/pcl/work/pcl-pcl-1.14.1/visualization/src/pcl_visualizer.cpp:102:
/usr/pkg/include/boost/uuid/detail/sha1.hpp:179:43: note: initializing argument 1 of 'void boost::uuids::detail::sha1::get_digest(unsigned char (&)[20])'
179 | inline void sha1::get_digest(digest_type& digest)
| ~~~~~~~~~~~~~^~~~~~
[35/290] Building CXX object tracking/CMakeFiles/pcl_tracking.dir/src/particle_filter.cpp.o
ninja: build stopped: subcommand failed.
*** Error code 1
Context
I'm building pcl in the context of pkgsrc, in a way that worked before. I had a successful build on September 19, with boost 1.85.0. This is on NetBSD 10 amd64, but the error hints at boost having an API change.
Expected behavior
The latest release builds with the latest release of boost.
Current Behavior
See build failure bove.
To Reproduce
Obtain pkgsrc from pkgsrc.org and build pcl.
Your Environment (please complete the following information):
- NetBSD 10, amd64
- gcc version 10.5.0 (nb2 20230710)
- PCL 1.14.1