Skip to content

The finishes are calibrated against flutter_tester's stepped blur, not what a device delivers #39

Open

Description

@PlugFox

Found while measuring #33 on devices. The finishes were calibrated headless, on flutter_tester's Skia raster, where the blur moves in steps: regular, asked for 2.6 texels, delivers 2.45 there, and 2.45 is what matched Apple's texture. On a device's GPU the blur does not step:

asked Skia (flutter_tester) Skia (S22 Ultra GPU) Impeller (iPad, S22) after 0.4.0
1.6 1.598 1.598 ~1.6
2.6 2.451 2.578 2.6 (own Gaussian, to 1-2%)
4.0 4.228 3.982 4.0
8.0 7.803 8.059 ~8.0

So on devices, Skia and Impeller alike, regular blurs about 2.6 texels, 5-7% more than the 2.45 that matched Apple's.

To decide: recalibrate the finishes' sigmas against what a device delivers (the meant sigma is the one that matched Apple, 2.45, not the one asked), and take the steps out of the tests' reference; or record it as within tolerance. Either way it needs the comparison against Apple's texture redone on a device.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions