Repository navigation
Commit a98ab08
committed
fix(test): skip MutationCollector real watcher suite on Windows
Windows + Node 24.x currently triggers an upstream libuv/fs.watch
assertion:
Assertion failed: !_wcsnicmp(filename, dir, dirlen), src\win\fs-event.c:72
Root cause is libuv 1.52.1 (bundled in Node 24.16.0) regressing short
path name handling for recursive fs.watch on Windows. Tracked in:
- nodejs/node#63638 (regression from libuv 1.52.1)
- libuv/libuv#5010 (short path handling)
Node 24.15.0 is the last known-good version.
MutationCollector business logic (addCandidate, collect merging, Git
status path, workspace boundary check, releaseWatchers concept) is
covered by MutationCollector > 17/18/19/20 in code-commit3-acceptance.
This describe only exercises real fs.watch event capture, which is
cross-platform infrastructure behavior tightly coupled to the upstream
bug.
Skip the entire describe block on Windows via describe.skipIf so:
- CI stops flaking on a Node/libuv issue we can't fix from JS.
- Linux/macOS keep running the integration test.
- All MutationCollector business coverage is preserved.
Re-enable when libuv PR #5152 is cherry-picked into a Node 24.x LTS
release.1 parent 6f00b25 commit a98ab08
1 file changed
Lines changed: 17 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
332 | 332 | | |
333 | 333 | | |
334 | 334 | | |
335 | | - | |
336 | | - | |
| 335 | + | |
| 336 | + | |
| 337 | + | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
| 344 | + | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
337 | 352 | | |
338 | 353 | | |
339 | 354 | | |
| |||
0 commit comments