Skip to content

Initial tests for 2D OpenPMD sample - #499

Closed
StanczakDominik wants to merge 1 commit into
masterfrom
openpmd-subclass
Closed

Initial tests for 2D OpenPMD sample#499
StanczakDominik wants to merge 1 commit into
masterfrom
openpmd-subclass

Conversation

@StanczakDominik

@StanczakDominik StanczakDominik commented Jun 16, 2018

Copy link
Copy Markdown
Member

All right, @ritiek, this is what I came up with for the initial test. I just went in and handled the 2D example dataset to begin with; we can move ahead to the 3D and the theta one later on, once we have something we're happy with.

I updated the gist with an exploratory notebook via h5py (I haven't checked out the API yet).

I'm not sure about a few issues here: I think you'll find the notes in tests.

This was weird to write as I couldn't quite test it as I except the whole thing to fail instantly as we aren't handling hdf5's yet.

@StanczakDominik StanczakDominik added the plasmapy.plasma Related to the plasmapy.plasma subpackage label Jun 16, 2018
@StanczakDominik StanczakDominik added this to the v0.2.0 milestone Jun 16, 2018
@pep8speaks

pep8speaks commented Jun 16, 2018

Copy link
Copy Markdown

Hello @StanczakDominik! Thanks for submitting your pull request.

Line 6:1: E302 expected 2 blank lines, found 1
Line 10:100: E501 line too long (100 > 99 characters)
Line 19:1: E302 expected 2 blank lines, found 1
Line 23:1: E302 expected 2 blank lines, found 1
Line 27:1: E302 expected 2 blank lines, found 1
Line 32:1: E302 expected 2 blank lines, found 1
Line 36:1: E302 expected 2 blank lines, found 1
Line 42:1: E302 expected 2 blank lines, found 1
Line 46:1: W391 blank line at end of file

PlasmaPy follows the PEP8 style guide, which may be checked locally using pycodestyle

@ritiek

ritiek commented Jun 16, 2018

Copy link
Copy Markdown
Contributor

Thanks and that gist is something I'll certainly have to refer to :) As I see from the tests, we're going to be integrate our subclass with numpy and astropy.units, seems a very good idea.

By the way, should we use openPMD bindings for python or just stick with h5py? I could get openPMD working for python using conda installation method but spack and building from source were a pain in vain for me. If you're going to try it, you might have better luck with conda like me.

@ritiek

ritiek commented Jun 17, 2018

Copy link
Copy Markdown
Contributor

I made a basic skeleton here. Should I merge your changes on my branch and open a separate PR to PlasmaPy? I can't push stuff to your branch directly. :D

@StanczakDominik

StanczakDominik commented Jun 17, 2018

Copy link
Copy Markdown
Member Author

Simply merge mine into your branch and open up a separate PR, then we can close this one :) I think it's fitting for you to get #500. 😄

@ritiek ritiek mentioned this pull request Jun 17, 2018
Merged
@StanczakDominik
StanczakDominik deleted the openpmd-subclass branch August 15, 2018 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

plasmapy.plasma Related to the plasmapy.plasma subpackage

Projects

None yet

Milestone

v0.2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@StanczakDominik @pep8speaks @ritiek