Repository navigation
Update requirements setup - #2650
Merged
Merged
Conversation
github-actions
Bot
added
testing
CI
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2650 +/- ##
=======================================
Coverage 95.22% 95.22%
=======================================
Files 103 103
Lines 9401 9401
Branches 2151 2151
=======================================
Hits 8952 8952
Misses 274 274
Partials 175 175 ☔ View full report in Codecov by Sentry. |
github-actions
Bot
added
the
docs
Member
Author
|
@rocco8773 — Since this PR addresses some of the points brought up in #2647, would you be able to give this a review? I'm hoping to keep this PR limited in scope 🔬, but we can use #2647 to discuss larger scope changes 🔭. |
Member
Author
github-actions
Bot
removed
the
status: ready for review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR partially addresses #2647 by:
requirements/toci_requirements/to indicate that the files contained therein are specifically for CI. (This may also have side benefit of making dependabot ignore the files in this directory.)ci_requirements/README.mdto describe the purpose of the directory.pyproject.tomlabout regenerating requirements files.I considered removing
requirements.txtin this PR, but I wanted to isolate those changes in case anything unexpected happens.This PR doesn't need to be included in our v2024.5.0 release, which I'm expected to do on Friday.