Repository navigation
astropy.units.core.UnitConversionError: 's / m' and 's / m' are not convertible #587
Description
After wrestling with system packages (conda, pip and pacman, argh!), I've managed to figure out that this is localized to astropy 3.1. Also, running python setup.py test -d and getting into plasmapy.physics.distribution.Maxwellian_1D:
(Pdb) distFunc
<Quantity 5.91632969e-07 s / m>
(Pdb) p u.s / u.m
Unit("s / m")
(Pdb) p distFunc
<Quantity 5.91632969e-07 s / m>
(Pdb) p distFunc.unit
Unit("s / m")
(Pdb) p distFunc.to(u.s / u.m)
*** astropy.units.core.UnitConversionError: 's / m' and 's / m' are not convertible
Activity
StanczakDominik commentedon Dec 12, 2018
Looks like this is going to be fixed for Astropy 3.1.1 in astropy/astropy#8263 which leaves us to figure out how to block 3.1 in requirements. Basically we want to say
Astropy >= 3.0.2 & Astropy != 3.1.0"manasbedmutha98 commentedon Dec 12, 2018
I could find only this as the package installation file having astropy. Should this be made to
Astropy >= 3.0.2 & Astropy != 3.1.0"or I am missing something?PlasmaPy/requirements/requirements.txt
Line 3 in 3e919ff
ritiek commentedon Dec 13, 2018
@manasbedmutha98 Yep, modifying that line to a format which requirements.txt accepts would be the way to go. I think replacing it with something like
astropy (>= 3.0.2, != 3.1.0)should work.Perhaps it would be also be a good idea to add a comment in requirements.txt referencing this issue for why we do not want
astropy v3.1.0.ritiek commentedon Dec 13, 2018
Wait. This doesn't seems to be working. If I
pip install "astropy==3.1.0"and then modify the astropy line inrequirements.txttoastropy (>= 3.0.2, != 3.1.0). It doesn't seem to install a different version (anything other thanv3.1.0) when runningpython setup.py install.This seems a problem specific to PlasmaPy as I am able to create a dummy
test.txtwith a line containingastropy (>= 3.0.2, != 3.1.0)and then when installing it withpip install -r test.txtit indeed downgrades tov3.0.5fromv3.1.0.