@@ -21,6 +21,8 @@ import {
2121import * as DateTime from "effect/DateTime" ;
2222import * as Effect from "effect/Effect" ;
2323import * as Layer from "effect/Layer" ;
24+ import * as Result from "effect/Result" ;
25+ import * as TestClock from "effect/testing/TestClock" ;
2426import * as SqlClient from "effect/sql/SqlClient" ;
2527import * as SqlitePersistence from "../persistence/Sqlite.ts" ;
2628import { CodexProviderCapabilitiesV2 } from "./Adapters/CodexAdapterV2.ts" ;
@@ -953,3 +955,86 @@ it.effect("wakes the parent once when its delegated task asks a question", () =>
953955 } ) ;
954956 } ) . pipe ( Effect . provide ( DelegatedTaskQuestionReactor . layer . pipe ( Layer . provideMerge ( layerTest ) ) ) ) ,
955957) ;
958+
959+ it . effect . each ( [ false , true ] ) ( "rejects thread.create for an existing id (deleted: %s)" , ( deleted ) =>
960+ Effect . gen ( function * ( ) {
961+ const orchestrator = yield * Orchestrator . OrchestratorV2 ;
962+ const projections = yield * ProjectionStore . ProjectionStoreV2 ;
963+ const threadId = ThreadId . make ( `thread:duplicate-create:${ deleted } ` ) ;
964+ const create = {
965+ type : "thread.create" ,
966+ commandId : CommandId . make ( `create:${ threadId } ` ) ,
967+ threadId,
968+ projectId : ProjectId . make ( "project:duplicate-create" ) ,
969+ title : "Original" ,
970+ modelSelection,
971+ runtimeMode : "full-access" ,
972+ interactionMode : "default" ,
973+ branch : null ,
974+ worktreePath : null ,
975+ createdBy : "user" ,
976+ creationSource : "web" ,
977+ importedNativeThread : {
978+ ref : { driver : adapter . driver , nativeId : "native-original" , strength : "strong" } ,
979+ } ,
980+ } as const ;
981+ yield * orchestrator . dispatch ( create ) ;
982+ if ( deleted ) {
983+ yield * orchestrator . dispatch ( {
984+ type : "thread.delete" ,
985+ commandId : CommandId . make ( `delete:${ threadId } ` ) ,
986+ threadId,
987+ } ) ;
988+ }
989+ const before = yield * projections . getThread ( threadId ) ;
990+ assert . isNotNull ( before . activeProviderThreadId ) ;
991+ assert . equal ( before . deletedAt !== null , deleted ) ;
992+ const sequence = yield * orchestrator . getThreadEventSequence ( threadId ) ;
993+ yield * TestClock . adjust ( "1 second" ) ;
994+ const duplicate = {
995+ ...create ,
996+ commandId : CommandId . make ( `duplicate:${ threadId } ` ) ,
997+ title : "Replacement" ,
998+ importedNativeThread : undefined ,
999+ } ;
1000+ const outcome = yield * orchestrator . dispatch ( duplicate ) . pipe ( Effect . result ) ;
1001+ assert . ok ( Result . isFailure ( outcome ) , "duplicate create must be rejected" ) ;
1002+ const refused = outcome . failure ;
1003+ assert . equal ( refused . _tag , "OrchestratorThreadAlreadyExistsError" ) ;
1004+ assert . equal ( refused . message , `Thread ${ threadId } already exists. Use a new thread id.` ) ;
1005+ assert . deepEqual ( yield * projections . getThread ( threadId ) , before ) ;
1006+ assert . equal ( yield * orchestrator . getThreadEventSequence ( threadId ) , sequence ) ;
1007+ const retried = yield * orchestrator . dispatch ( duplicate ) . pipe ( Effect . flip ) ;
1008+ assert . equal ( retried . _tag , "OrchestratorCommandPreviouslyRejectedError" ) ;
1009+ assert . include ( retried . message , refused . message ) ;
1010+ } ) . pipe ( Effect . provide ( layerTest ) ) ,
1011+ ) ;
1012+
1013+ it . effect ( "replays a thread.create receipt without changing the thread" , ( ) =>
1014+ Effect . gen ( function * ( ) {
1015+ const orchestrator = yield * Orchestrator . OrchestratorV2 ;
1016+ const projections = yield * ProjectionStore . ProjectionStoreV2 ;
1017+ const threadId = ThreadId . make ( "thread:create-receipt-replay" ) ;
1018+ const create = {
1019+ type : "thread.create" ,
1020+ commandId : CommandId . make ( "create:receipt-replay" ) ,
1021+ threadId,
1022+ projectId : ProjectId . make ( "project:duplicate-create" ) ,
1023+ title : "Original" ,
1024+ modelSelection,
1025+ runtimeMode : "full-access" ,
1026+ interactionMode : "default" ,
1027+ branch : null ,
1028+ worktreePath : null ,
1029+ createdBy : "user" ,
1030+ creationSource : "web" ,
1031+ } as const ;
1032+ const original = yield * orchestrator . dispatch ( create ) ;
1033+ const before = yield * projections . getThread ( threadId ) ;
1034+ const replayed = yield * orchestrator . dispatch ( create ) ;
1035+ assert . equal ( replayed . sequence , original . sequence ) ;
1036+ assert . deepEqual ( replayed , original ) ;
1037+ assert . deepEqual ( yield * projections . getThread ( threadId ) , before ) ;
1038+ assert . equal ( yield * orchestrator . getThreadEventSequence ( threadId ) , original . sequence ) ;
1039+ } ) . pipe ( Effect . provide ( layerTest ) ) ,
1040+ ) ;
0 commit comments