Skip to content

Commit edd6fc3

Browse files
fix(server): ACP streamed chunks compare message ids exactly (pingdotgg#35836)
1 parent 95cb068 commit edd6fc3

2 files changed

Lines changed: 14 additions & 1 deletion

File tree

‎apps/server/src/orchestration-v2/Adapters/AcpAdapterV2.test.ts‎

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2878,6 +2878,19 @@ describe("AcpAdapterV2", () => {
28782878
["reasoning", "Thinking more"],
28792879
],
28802880
},
2881+
{
2882+
label: "opaque ids differ only in surrounding whitespace",
2883+
steps: [answer("answer", "A"), answer(" answer ", "B")],
2884+
expected: [
2885+
["assistant_message", "A"],
2886+
["assistant_message", "B"],
2887+
],
2888+
},
2889+
{
2890+
label: "a chunk continues a full update with the same whitespace-padded id",
2891+
steps: [agentMessage(" answer ", "A"), answer(" answer ", "B")],
2892+
expected: [["assistant_message", "AB"]],
2893+
},
28812894
] satisfies ReadonlyArray<{
28822895
readonly label: string;
28832896
readonly steps: ReadonlyArray<ScriptedTextStep>;

‎packages/provider-acp/src/server/adapter.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3002,7 +3002,7 @@ export const makeAcpAdapterV2 = Effect.fn("makeAcpAdapterV2")(function* (
30023002
if (other !== kind) yield* closeTextStream(context, other);
30033003
}
30043004
const stream = textStreamFor(context, kind);
3005-
const sourceMessageId = messageId?.trim() || null;
3005+
const sourceMessageId = messageId || null;
30063006
if (
30073007
stream.current !== null &&
30083008
sourceMessageId !== null &&

0 commit comments

Comments
 (0)