Skip to content

Commit ac77f4f

Browse files
authored
fix(server): failed Cursor turns show Cursor's reason (pingdotgg#16146)
1 parent 49e00ee commit ac77f4f

4 files changed

Lines changed: 218 additions & 10 deletions

File tree

‎packages/provider-cursor/src/server/CursorAgentSdk.test.ts‎

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -305,4 +305,34 @@ describe("CursorAgentSdkRunner", () => {
305305
assert.equal(cursorSdkMock.runWait.mock.calls.length, 1);
306306
}).pipe(Effect.provide(layerTest)),
307307
);
308+
309+
it("names the SDK's reason, code and HTTP status in a runner failure's text", () => {
310+
const failed = (cause: unknown) =>
311+
CursorAgentSdk.cursorSdkFailureMessage(
312+
new CursorAgentSdk.CursorAgentSdkRunnerError({ method: "agent.create", cause }),
313+
);
314+
assert.equal(
315+
new CursorAgentSdk.CursorAgentSdkRunnerError({
316+
method: "agent.create",
317+
cause: new Error("Too many requests"),
318+
}).message,
319+
"Cursor Agent SDK agent.create failed.",
320+
);
321+
assert.equal(
322+
failed(Object.assign(new Error("Too many requests"), { code: "rate_limited", status: 429 })),
323+
"Cursor Agent SDK agent.create failed: Too many requests (rate_limited, HTTP 429)",
324+
);
325+
// Cursor's messages often start with the code already.
326+
assert.equal(
327+
failed(
328+
Object.assign(new Error("[resource_exhausted] Error"), { code: "resource_exhausted" }),
329+
),
330+
"Cursor Agent SDK agent.create failed: [resource_exhausted] Error",
331+
);
332+
assert.equal(
333+
failed(Object.assign(new Error("Invalid User API Key"), { code: "error", status: 401 })),
334+
"Cursor Agent SDK agent.create failed: Invalid User API Key (HTTP 401)",
335+
);
336+
assert.equal(failed(undefined), "Cursor Agent SDK agent.create failed.");
337+
});
308338
});

‎packages/provider-cursor/src/server/CursorAgentSdk.ts‎

Lines changed: 28 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,34 @@ export class CursorAgentSdkRunnerError extends Schema.TaggedError<CursorAgentSdk
3636
}
3737
}
3838

39-
const isCursorAgentSdkRunnerError = Schema.is(CursorAgentSdkRunnerError);
39+
/** The failure text a user sees: the SDK's own reason, which the error's message leaves out. */
40+
export function cursorSdkFailureMessage(error: CursorAgentSdkRunnerError): string {
41+
const reason = sdkErrorReason(error.cause);
42+
return reason === undefined
43+
? error.message
44+
: `Cursor Agent SDK ${error.method} failed: ${reason}`;
45+
}
46+
47+
/** Codes Cursor sends when it has no specific one. */
48+
const GENERIC_SDK_ERROR_CODES = new Set(["", "error", "unknown"]);
49+
50+
/** The SDK's own message, with the code and HTTP status its errors carry. */
51+
function sdkErrorReason(cause: unknown): string | undefined {
52+
if (!(cause instanceof Error)) return undefined;
53+
const message = cause.message.trim();
54+
if (message.length === 0) return undefined;
55+
const code = Reflect.get(cause, "code");
56+
const status = Reflect.get(cause, "status");
57+
const details = [
58+
...(typeof code === "string" && !GENERIC_SDK_ERROR_CODES.has(code) && !message.includes(code)
59+
? [code]
60+
: []),
61+
...(typeof status === "number" ? [`HTTP ${status}`] : []),
62+
];
63+
return details.length === 0 ? message : `${message} (${details.join(", ")})`;
64+
}
65+
66+
export const isCursorAgentSdkRunnerError = Schema.is(CursorAgentSdkRunnerError);
4067

4168
export interface CursorAgentSdkOpenInput {
4269
readonly operation: "create" | "resume";

‎packages/provider-cursor/src/server/adapter.test.ts‎

Lines changed: 141 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -222,6 +222,147 @@ describe("CursorAdapterV2", () => {
222222
),
223223
);
224224

225+
it.effect.each([
226+
{
227+
reason: "the error Cursor's run ended with",
228+
wait: Effect.succeed({
229+
id: "native-cursor-run",
230+
requestId: "native-request",
231+
status: "error" as const,
232+
error: {
233+
message: "Model Blocked Please ask your admin to enable access to Claude Fable 5.",
234+
},
235+
model: { id: "claude-fable-5" },
236+
durationMs: 1,
237+
}),
238+
failure: {
239+
class: "provider_error",
240+
message: "Model Blocked Please ask your admin to enable access to Claude Fable 5.",
241+
},
242+
},
243+
{
244+
reason: "the SDK error that broke the run",
245+
wait: Effect.fail(
246+
new CursorAgentSdk.CursorAgentSdkRunnerError({
247+
method: "run.wait",
248+
cause: Object.assign(new Error("Too many requests"), {
249+
code: "resource_exhausted",
250+
status: 429,
251+
}),
252+
}),
253+
),
254+
failure: {
255+
class: "transport_error",
256+
message:
257+
"Cursor Agent SDK run.wait failed: Too many requests (resource_exhausted, HTTP 429)",
258+
},
259+
},
260+
])("fails the turn with $reason", ({ wait, failure }) =>
261+
Effect.gen(function* () {
262+
const fileSystem = yield* FileSystem.FileSystem;
263+
const workspace = yield* fileSystem.makeTempDirectoryScoped({ prefix: "cursor-v2-failure-" });
264+
const instanceId = ProviderInstanceId.make("cursor");
265+
const threadId = ThreadId.make("cursor-failure-thread");
266+
const modelSelection = { instanceId, model: "claude-fable-5" };
267+
const runtimePolicy = ProviderAdapter.ProviderAdapterV2RuntimePolicy.make({
268+
runtimeMode: "full-access",
269+
interactionMode: "default",
270+
cwd: workspace,
271+
});
272+
const adapter = yield* makeCursorAdapterV2({
273+
instanceId,
274+
settings: yield* decodeCursorSettings({}),
275+
environment: { HOME: workspace },
276+
}).pipe(
277+
Effect.provideService(CursorAgentSdk.CursorAgentSdkRunner, {
278+
assertComplete: Effect.void,
279+
open: () =>
280+
Effect.succeed({
281+
agentId: "native-cursor-failure",
282+
listMessages: Effect.succeed([]),
283+
close: Effect.void,
284+
send: () =>
285+
Effect.succeed({
286+
agentId: "native-cursor-failure",
287+
runId: "native-cursor-run",
288+
wait,
289+
cancel: Effect.void,
290+
}),
291+
}),
292+
}),
293+
Effect.provide(TestProviderHost.layer({ cwd: workspace })),
294+
);
295+
const runtime = yield* adapter.openSession({
296+
threadId,
297+
providerSessionId: ProviderSessionId.make("cursor-failure-session"),
298+
modelSelection,
299+
runtimePolicy,
300+
});
301+
const providerThread = yield* runtime.ensureThread({
302+
threadId,
303+
modelSelection,
304+
runtimePolicy,
305+
});
306+
const now = yield* DateTime.now;
307+
yield* runtime.startTurn({
308+
threadId,
309+
providerThread,
310+
modelSelection,
311+
runtimePolicy,
312+
runId: RunId.make("cursor-failure-run"),
313+
runOrdinal: 1,
314+
providerTurnOrdinal: 1,
315+
attemptId: RunAttemptId.make("cursor-failure-attempt"),
316+
rootNodeId: NodeId.make("cursor-failure-root"),
317+
appThread: {
318+
id: threadId,
319+
projectId: ProjectId.make("cursor-failure-project"),
320+
createdBy: "user",
321+
creationSource: "web",
322+
title: "Cursor failure",
323+
providerInstanceId: instanceId,
324+
modelSelection,
325+
runtimeMode: "full-access",
326+
interactionMode: "default",
327+
branch: null,
328+
worktreePath: null,
329+
activeProviderThreadId: providerThread.id,
330+
lineage: { parentThreadId: null, relationshipToParent: null, rootThreadId: threadId },
331+
forkedFrom: null,
332+
createdAt: now,
333+
updatedAt: now,
334+
archivedAt: null,
335+
settledOverride: null,
336+
settledAt: null,
337+
lastVisitedAt: null,
338+
deletedAt: null,
339+
},
340+
message: {
341+
messageId: MessageId.make("cursor-failure-message"),
342+
createdBy: "user",
343+
creationSource: "web",
344+
text: "hi",
345+
attachments: [],
346+
},
347+
});
348+
const terminal = yield* runtime.events.pipe(
349+
Stream.filter((event) => event.type === "turn.terminal"),
350+
Stream.runHead,
351+
);
352+
assert.isTrue(Option.isSome(terminal));
353+
if (Option.isSome(terminal)) {
354+
assert.equal(terminal.value.status, "failed");
355+
assert.equal(terminal.value.failure?.class, failure.class);
356+
assert.equal(terminal.value.failure?.message, failure.message);
357+
}
358+
}).pipe(
359+
Effect.scoped,
360+
Effect.provide(
361+
Layer.mergeAll(NodeServices.layer, IdAllocator.layer, McpProviderSessions.layer),
362+
),
363+
),
364+
);
365+
225366
it.effect("fails standalone SDK transport diagnostics and sends compaction as /compress", () =>
226367
Effect.gen(function* () {
227368
const fileSystem = yield* FileSystem.FileSystem;

‎packages/provider-cursor/src/server/adapter.ts‎

Lines changed: 19 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2341,14 +2341,18 @@ export const makeCursorAdapterV2 = Effect.fn("makeCursorAdapterV2")(function* (
23412341
status,
23422342
...(status === "failed"
23432343
? {
2344-
failure: makeProviderFailure({
2345-
cause:
2346-
transportFailure ?? (result as { readonly error?: unknown }).error,
2347-
class:
2348-
transportFailure === undefined
2349-
? "provider_error"
2350-
: "transport_error",
2351-
}),
2344+
failure:
2345+
transportFailure === undefined
2346+
? makeProviderFailure({
2347+
cause: result.error,
2348+
// makeProviderFailure never reads a cause's own text.
2349+
message: result.error?.message,
2350+
class: "provider_error",
2351+
})
2352+
: makeProviderFailure({
2353+
cause: transportFailure,
2354+
class: "transport_error",
2355+
}),
23522356
}
23532357
: {}),
23542358
});
@@ -2364,7 +2368,13 @@ export const makeCursorAdapterV2 = Effect.fn("makeCursorAdapterV2")(function* (
23642368
...(context.interrupted
23652369
? {}
23662370
: {
2367-
failure: makeProviderFailure({ cause, class: "transport_error" }),
2371+
failure: makeProviderFailure({
2372+
cause,
2373+
message: CursorAgentSdk.isCursorAgentSdkRunnerError(cause)
2374+
? CursorAgentSdk.cursorSdkFailureMessage(cause)
2375+
: undefined,
2376+
class: "transport_error",
2377+
}),
23682378
}),
23692379
});
23702380
}

0 commit comments

Comments
 (0)