Skip to content

Commit 9529ee3

Browse files
authored
fix(contracts): a stored secret reference is always sensitive (pingdotgg#31403)
Signed-off-by: Yordis Prieto <[email protected]>
1 parent 221d8b8 commit 9529ee3

2 files changed

Lines changed: 20 additions & 1 deletion

File tree

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
import * as Schema from "effect/Schema";
2+
import { describe, expect, it } from "vite-plus/test";
3+
4+
import { ProviderInstanceEnvironmentVariable } from "./providerInstance.ts";
5+
6+
const decodeEnvironmentVariable = Schema.decodeUnknownSync(ProviderInstanceEnvironmentVariable);
7+
8+
describe("ProviderInstanceEnvironmentVariable", () => {
9+
it("treats a stored reference as sensitive even when the flag is missing or false", () => {
10+
const secret = { provider: "onepassword", reference: "op://Private/item/field" };
11+
expect(decodeEnvironmentVariable({ name: "API_KEY", secret })).toMatchObject({
12+
value: secret,
13+
sensitive: true,
14+
});
15+
expect(decodeEnvironmentVariable({ name: "API_KEY", sensitive: false, secret }).sensitive).toBe(
16+
true,
17+
);
18+
});
19+
});

‎packages/contracts/src/providerInstance.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ export const ProviderInstanceEnvironmentVariable = StoredProviderInstanceEnviron
5353
typeof StoredProviderInstanceEnvironmentVariable.Type
5454
>({
5555
decode: ({ secret, ...variable }) =>
56-
secret === undefined ? variable : { ...variable, value: secret },
56+
secret === undefined ? variable : { ...variable, value: secret, sensitive: true },
5757
encode: ({ value, ...variable }) =>
5858
typeof value === "string"
5959
? { ...variable, value }

0 commit comments

Comments
 (0)