Skip to content

Commit 5f85768

Browse files
fix(codex): image items identified by fileId are no longer dropped (pingdotgg#35883)
1 parent a2be070 commit 5f85768

3 files changed

Lines changed: 123 additions & 37 deletions

File tree

‎packages/effect-codex-app-server/scripts/generate.ts‎

Lines changed: 29 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -188,6 +188,32 @@ function openStringEnum(schema: Schema.Json): Schema.Json {
188188
};
189189
}
190190

191+
// Newer Codex identifies a generated image by `fileId` and omits the inline `result`.
192+
// Requiring `result` fails the whole notification decode and drops the finished image.
193+
function acceptImageFileIds(schema: Schema.Json): Schema.Json {
194+
if (!isJsonSchemaNode(schema) || !Array.isArray(schema.oneOf)) return schema;
195+
return {
196+
...schema,
197+
oneOf: schema.oneOf.map((variant: Schema.Json) => {
198+
if (
199+
!isJsonSchemaNode(variant) ||
200+
!isJsonSchemaNode(variant.properties) ||
201+
!isJsonSchemaNode(variant.properties.type) ||
202+
!Array.isArray(variant.properties.type.enum) ||
203+
!variant.properties.type.enum.includes("imageGeneration") ||
204+
!Array.isArray(variant.required)
205+
) {
206+
return variant;
207+
}
208+
return {
209+
...variant,
210+
properties: { ...variant.properties, fileId: { type: "string" } },
211+
required: variant.required.filter((key: Schema.Json) => key !== "result"),
212+
};
213+
}),
214+
};
215+
}
216+
191217
const getGeneratedPaths = Effect.fn("getGeneratedPaths")(function* () {
192218
const path = yield* Path.Path;
193219
const generatedDir = path.join(import.meta.dirname, "..", "src", "_generated");
@@ -684,7 +710,9 @@ const generateFiles = Effect.fn("generateFiles")(function* () {
684710
DefinitionOverrides[definitionName] ??
685711
(OpenStringEnumDefinitions.has(definitionName)
686712
? openStringEnum(definitionSchema)
687-
: definitionSchema),
713+
: definitionName === "ThreadItem"
714+
? acceptImageFileIds(definitionSchema)
715+
: definitionSchema),
688716
localDefinitionNames,
689717
file.namespace,
690718
exportNameByQualifiedName,

0 commit comments

Comments
 (0)