|
1 | 1 | import { assert, describe, expect, it } from "@effect/vitest"; |
2 | 2 | import * as Effect from "effect/Effect"; |
3 | 3 | import * as Layer from "effect/Layer"; |
| 4 | +import * as TestClock from "effect/testing/TestClock"; |
4 | 5 |
|
5 | 6 | import * as GitLabCli from "./GitLabCli.ts"; |
6 | 7 | import * as GitLabPullRequestCli from "./GitLabPullRequestCli.ts"; |
@@ -122,6 +123,157 @@ describe("getChangeRequest base freshness", () => { |
122 | 123 | ); |
123 | 124 | }); |
124 | 125 |
|
| 126 | +describe("merge request reads", () => { |
| 127 | + const reference = { cwd: "/w", repository: "acme/web", host: "gitlab.com", number: 7 }; |
| 128 | + const detail = { |
| 129 | + number: 7, |
| 130 | + title: "Merge request 7", |
| 131 | + url: "https://gitlab.com/acme/web/-/merge_requests/7", |
| 132 | + author: null, |
| 133 | + headBranch: "feat/page", |
| 134 | + baseBranch: "main", |
| 135 | + state: "open" as const, |
| 136 | + isDraft: false, |
| 137 | + mergeability: "mergeable" as const, |
| 138 | + additions: 0, |
| 139 | + deletions: 0, |
| 140 | + createdAt: "2026-07-01T00:00:00Z", |
| 141 | + updatedAt: "2026-07-02T00:00:00Z", |
| 142 | + reviewRequestLogins: [], |
| 143 | + labels: [], |
| 144 | + body: "", |
| 145 | + changedFiles: 1, |
| 146 | + mergedAt: null, |
| 147 | + closedAt: null, |
| 148 | + reviewers: [], |
| 149 | + checks: [], |
| 150 | + viewerCanMerge: true, |
| 151 | + reviewerIds: [], |
| 152 | + }; |
| 153 | + |
| 154 | + const countingProvider = Effect.gen(function* () { |
| 155 | + const calls = { detail: 0, mergeCapabilities: 0 }; |
| 156 | + const host = { viewerCanMerge: true }; |
| 157 | + const provider = yield* make.pipe( |
| 158 | + Effect.provide( |
| 159 | + Layer.mock(GitLabPullRequestCli.GitLabPullRequestCli)({ |
| 160 | + getMergeRequestDetail: (input) => |
| 161 | + Effect.sync(() => { |
| 162 | + calls.detail += 1; |
| 163 | + return { ...detail, number: input.number, viewerCanMerge: host.viewerCanMerge }; |
| 164 | + }), |
| 165 | + getProjectMergeCapabilities: () => |
| 166 | + Effect.sync(() => { |
| 167 | + calls.mergeCapabilities += 1; |
| 168 | + return { merge: true, squash: true, rebase: true }; |
| 169 | + }), |
| 170 | + runMergeRequestAction: () => Effect.void, |
| 171 | + }), |
| 172 | + ), |
| 173 | + ); |
| 174 | + const checks = provider.getChangeRequestChecks; |
| 175 | + const forget = provider.forgetChangeRequestReads; |
| 176 | + if (checks === undefined || forget === undefined) { |
| 177 | + return yield* Effect.die("GitLab answers checks and forgets its reads"); |
| 178 | + } |
| 179 | + return { provider, checks, forget, calls, host }; |
| 180 | + }); |
| 181 | + |
| 182 | + it.effect("asks for a project's merge methods once across its merge requests", () => |
| 183 | + Effect.gen(function* () { |
| 184 | + const { provider, calls } = yield* countingProvider; |
| 185 | + |
| 186 | + yield* provider.getChangeRequest(reference); |
| 187 | + yield* provider.getChangeRequest(reference); |
| 188 | + yield* provider.getChangeRequest({ ...reference, number: 8 }); |
| 189 | + |
| 190 | + expect(calls.mergeCapabilities).toBe(1); |
| 191 | + }), |
| 192 | + ); |
| 193 | + |
| 194 | + it.effect("answers checks from the merge request the detail just read", () => |
| 195 | + Effect.gen(function* () { |
| 196 | + const { provider, checks, calls } = yield* countingProvider; |
| 197 | + |
| 198 | + yield* provider.getChangeRequest(reference); |
| 199 | + yield* checks(reference); |
| 200 | + |
| 201 | + expect(calls.detail).toBe(1); |
| 202 | + }), |
| 203 | + ); |
| 204 | + |
| 205 | + it.effect("reads a merge request again after a write to it", () => |
| 206 | + Effect.gen(function* () { |
| 207 | + const { provider, checks, calls } = yield* countingProvider; |
| 208 | + |
| 209 | + yield* provider.getChangeRequest(reference); |
| 210 | + yield* provider.runAction({ ...reference, action: "ready" }); |
| 211 | + yield* checks(reference); |
| 212 | + |
| 213 | + expect(calls.detail).toBe(2); |
| 214 | + }), |
| 215 | + ); |
| 216 | + |
| 217 | + it.effect("does not share reads between checkouts", () => |
| 218 | + Effect.gen(function* () { |
| 219 | + const { provider, calls } = yield* countingProvider; |
| 220 | + |
| 221 | + yield* provider.getChangeRequest(reference); |
| 222 | + yield* provider.getChangeRequest({ ...reference, cwd: "/other" }); |
| 223 | + |
| 224 | + expect(calls).toEqual({ detail: 2, mergeCapabilities: 2 }); |
| 225 | + }), |
| 226 | + ); |
| 227 | + |
| 228 | + it.effect("reads a merge request again once a minute has passed", () => |
| 229 | + Effect.gen(function* () { |
| 230 | + const { provider, calls } = yield* countingProvider; |
| 231 | + |
| 232 | + yield* provider.getChangeRequest(reference); |
| 233 | + yield* TestClock.adjust("61 seconds"); |
| 234 | + yield* provider.getChangeRequest(reference); |
| 235 | + |
| 236 | + expect(calls.detail).toBe(2); |
| 237 | + }), |
| 238 | + ); |
| 239 | + |
| 240 | + it.effect("answers viewer permissions from the host, not the page's read", () => |
| 241 | + Effect.gen(function* () { |
| 242 | + const { provider, host } = yield* countingProvider; |
| 243 | + |
| 244 | + host.viewerCanMerge = false; |
| 245 | + yield* provider.getChangeRequest(reference); |
| 246 | + host.viewerCanMerge = true; |
| 247 | + const granted = yield* provider.getViewerPermissions(reference); |
| 248 | + host.viewerCanMerge = false; |
| 249 | + const revoked = yield* provider.getViewerPermissions(reference); |
| 250 | + |
| 251 | + expect(granted.actions).toContain("merge"); |
| 252 | + expect(revoked.actions).not.toContain("merge"); |
| 253 | + }), |
| 254 | + ); |
| 255 | + |
| 256 | + it.effect("reads a merge request again once its reads are forgotten", () => |
| 257 | + Effect.gen(function* () { |
| 258 | + const { provider, checks, forget, calls } = yield* countingProvider; |
| 259 | + const other = { ...reference, repository: "acme/api" }; |
| 260 | + |
| 261 | + yield* provider.getChangeRequest(reference); |
| 262 | + yield* provider.getChangeRequest(other); |
| 263 | + yield* forget({ repository: "ACME/web", number: 7 }); |
| 264 | + yield* checks(reference); |
| 265 | + yield* checks(other); |
| 266 | + expect(calls.detail).toBe(3); |
| 267 | + |
| 268 | + yield* forget({ repository: "acme/web" }); |
| 269 | + yield* checks(reference); |
| 270 | + yield* forget(); |
| 271 | + yield* checks(other); |
| 272 | + expect(calls.detail).toBe(5); |
| 273 | + }), |
| 274 | + ); |
| 275 | +}); |
| 276 | + |
125 | 277 | describe("optional activity reads", () => { |
126 | 278 | const reference = { cwd: "/w", repository: "acme/web", host: "gitlab.com", number: 7 }; |
127 | 279 | const comment = { |
|
0 commit comments