Skip to content

Commit 09647d1

Browse files
authored
fix(shared): CSV and TSV attachments keep their table under generic file types (pingdotgg#30601)
1 parent 1b14cb3 commit 09647d1

2 files changed

Lines changed: 8 additions & 2 deletions

File tree

‎packages/shared/src/delimitedPreview.test.ts‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,11 @@
11
import { describe, expect, it } from "vite-plus/test";
2-
import { parseDelimitedPreview } from "./delimitedPreview.ts";
2+
import { filePreviewDelimiter, parseDelimitedPreview } from "./delimitedPreview.ts";
33

44
describe("delimited file previews", () => {
5+
it("falls back to the file name under generic MIME types", () => {
6+
expect(filePreviewDelimiter({ name: "a.csv", mimeType: "binary/octet-stream" })).toBe(",");
7+
expect(filePreviewDelimiter({ name: "a.tsv", mimeType: "application/unknown" })).toBe("\t");
8+
});
59
it("preserves quoted separators, escaped quotes, blank cells and line breaks", () => {
610
expect(
711
parseDelimitedPreview('\ufeffname,notes,empty\r\n"A, B","say ""hi""\nagain",\r\n', ","),

‎packages/shared/src/delimitedPreview.ts‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
1+
import { GENERIC_MIME_TYPES } from "./image.ts";
2+
13
export function filePreviewDelimiter(file: { name: string; mimeType?: string }): "," | "\t" | null {
24
const mime = file.mimeType?.split(";", 1)[0]?.trim().toLowerCase();
35
if (mime === "text/csv") return ",";
46
if (mime === "text/tab-separated-values") return "\t";
5-
if (mime && mime !== "text/plain" && mime !== "application/octet-stream") return null;
7+
if (mime && mime !== "text/plain" && !GENERIC_MIME_TYPES.has(mime)) return null;
68
if (/\.csv$/i.test(file.name)) return ",";
79
if (/\.tsv$/i.test(file.name)) return "\t";
810
return null;

0 commit comments

Comments
 (0)