Skip to content

Commit 8b5cfe1

Browse files
Add platform_views_layout to build_tests so iOS/Android build breaks are caught in presubmit (flutter#192985)
`dev/benchmarks/platform_views_layout` is only ever built by post-submit devicelab benchmarks (`Mac_ios platform_views_scroll_perf_*` and `Linux_pixel_7pro`/`Linux_mokey platform_views_scroll_perf*`). It is also the only app in the repo that depends on the `google_mobile_ads` plugin, so a change that breaks native plugin integration for that app is invisible to presubmit. That is exactly what happened with flutter#185431 (Xcode 26.2 / iOS 26 CI upgrade): the `GoogleMobileAds` xcframework failed to link (missing `__swift_FORCE_LOAD_$_swiftCompatibility*` and libc++ symbols) only in the post-submit `Mac_ios platform_views_scroll_perf_*` devicelab tasks (flutter#185510), and the PR had to be reverted (flutter#185513) before being fixed by enabling SwiftPM for the plugin (flutter#185548). Building this app in the `build_tests` shard would have surfaced the failure on the presubmit `Mac_arm64 build_tests_*` builders instead. This PR adds the directory to `exampleDirectories` in `_runBuildTests` (`dev/bots/test.dart`). `_runExampleProjectBuildTests` only builds platforms whose project folder exists, so concretely this adds: | Host | Commands added | |---|---| | Linux / Mac / Windows `build_tests_*` | `flutter build apk --debug -v`, `flutter build apk --release -v` | | Mac `build_tests_*` only | `flutter build ios --no-codesign --debug -v`, `flutter build ios --no-codesign --release -v` | No web / macOS / Linux / Windows desktop build is attempted (the app has no such folders, and the shard prints e.g. `has no linux directory, skipping Linux` — verified with `--dry-run`). Sub-sharding is `{index}_{total}` driven by the `SUBSHARD` env var and the test list is shuffled with a fixed seed, so **no `.ci.yaml` change is needed**. The `build_tests` test count goes from 27 → 28 across 5 subshards (Linux/Mac) and 9 (Windows); the new entry lands in `4_5` on Linux with the current seed. **_With the help of Gemini_** Fixes flutter#185538 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant in-code documentation (doc comments with `///`). *(N/A — added an inline `//` comment explaining why the entry exists; no public API touched.)* - [x] If this PR introduces a new feature or capability, I created and linked a website documentation issue or PR in [flutter/website] (or verified none is needed). *(Verified none is needed — CI-only change.)* - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. *(**test-exempt**: this is a CI configuration change to `dev/bots/test.dart`; the change is exercised directly by the `Linux/Mac/Windows build_tests_*` presubmit builders on this very PR.)* - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. *(Not a breaking change.)* - [ ] All existing and new tests are passing. *(Pending CI — see "Verification" below for what was run locally.)* <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [flutter/website]: https://github.com/flutter/website [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md Co-authored-by: Victoria Ashworth <[email protected]>
1 parent 65dc9bc commit 8b5cfe1

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

‎dev/bots/test.dart‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -385,6 +385,10 @@ Future<void> _runBuildTests() async {
385385
.cast<Directory>()
386386
.toList()
387387
..add(Directory(path.join(flutterRoot, 'packages', 'integration_test', 'example')))
388+
// Depends on the google_mobile_ads plugin, so its Android and iOS builds
389+
// exercise native plugin integration that would otherwise only be built
390+
// by post-submit devicelab benchmarks. See flutter/flutter#185538.
391+
..add(Directory(path.join(flutterRoot, 'dev', 'benchmarks', 'platform_views_layout')))
388392
..add(
389393
Directory(
390394
path.join(flutterRoot, 'dev', 'integration_tests', 'android_semantics_testing'),

0 commit comments

Comments
 (0)