Repository navigation
fix: write score and badge to manifest meta for seeds and macros - #222
jochemvandooren merged 1 commit into
Conversation
The manifest formatter wrote the computed score and badge into the meta of models, snapshots, sources and exposures, but had no branch for seeds or macros. Both are fully supported evaluables that get scored, so `dbt-score lint --format manifest` silently dropped their scores. Add seeds to the nodes branch and a dedicated macros branch so their nodes carry meta.score and meta.badge like every other evaluable type.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe manifest formatter now writes ChangesManifest metadata output
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This localized change adds manifest score and badge metadata for seed and macro nodes, with regression coverage; no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jochemvandooren
left a comment
There was a problem hiding this comment.
Nice, thanks for picking it up! Code look good 👌
|
Thanks for the quick review, @jochemvandooren! Glad it looks good. |
Closes #221
ManifestFormatter.project_evaluatedwrotemeta.score/meta.badgefor models, snapshots, sources and exposures, but had no branch for seeds or macros — sodbt-score lint --format manifestemitted a manifest where seed and macro nodes carried no score, even though they are scored like everything else and their results sit in_evaluable_scores.Seeds live under
manifest["nodes"]alongside models/snapshots, so this addsseedto that branch; macros live under the separatemanifest["macros"]key, so they get their own branch. Thehuman_readableandjsonformatters were already correct (they key off the evaluable type generically); this only touches the manifest formatter.Added a regression test using the existing
tests/resources/manifest.jsonfixture (which already contains seeds and macros): it asserts seed and macro nodes carrymeta.scoreandmeta.badgeafter formatting. It fails onmaster(emptymeta) and passes with this change. Full formatter suite green, ruff and mypy clean.