fix: bug(gateway) - anchor startup error check to container start time#21
Merged
fix: bug(gateway) - anchor startup error check to container start time#21
Conversation
Root cause: The 'Gateway status check (no startup errors)' test used docker logs --since=5m (a rolling 5-minute window), which captures normal gateway startup messages that contain 'Error' substrings (specifically allowPathPositionals config warning and Unknown config keys validation message). These 2 benign startup messages caused the check to fail with 'Expected 0, Got 2'. Fix: - Use $keyword_since (container start time, already computed for KI-035 checks) instead of rolling --since=5m anchor - Add grep -v exclusions for known false-positive startup patterns: * allowPathPositionals (yargs startup config warning) * Unknown config keys (openclaw config validation warning) - Apply same fix to 'No missing environment variable errors' check Fixes #11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes gateway health check false positives from rolling log window.
Root Cause
The
Gateway status check (no startup errors)test useddocker logs --since=5m(a rolling 5-minute window from execution time). After each deploy/restart, the gateway logs 2 benign startup messages that containErrorsubstrings:allowPathPositionals— yargs CLI startup config warningUnknown config keys— openclaw config validation warningThese 2 lines caused the check to fail with
Expected 0, Got 2in CI immediately after container restart.Fix
--since=5m(rolling window) with--since=$keyword_since(anchored to container start time, consistent with existing KI-035 checks)grep -v 'allowPathPositionals'andgrep -v 'Unknown config keys'to exclude known false-positive startup patterns$keyword_sinceanchor toNo missing environment variable errorscheckFiles Changed
tests/regression-tests.sh— Gateway Health section updatedFixes #11