Repository navigation
Commit a616831
authored
test: reuse null-aware join fuzz reference results (apache#26838)
> [!IMPORTANT]
>
> **Fork CI setup:** For pull requests from a fork to `main`, enable
workflows in your fork's **Actions** tab before you push.
> See the [fork CI setup
guide](https://datafusion.apache.org/contributor-guide/#pull-requests-from-forks).
## Which issue does this PR close?
Part of apache#26759 and apache#13813.
## Rationale for this change
The null-aware join fuzzer reruns each reference query for every
batch-size and partition configuration. Each seed uses immutable tables,
so those expected rows can be computed once and reused.
## What changes are included in this PR?
Build the query cases once and cache their reference rows per seed in a
single-partition reference context. Every actual query/configuration
combination still runs, with the existing diagnostics and anti-join
plan-shape assertions.
## What is the testing strategy for this PR?
Original paired `ci`-profile runs with the same worker limit took 211s
before the change and 118s after it. These are single runs on a shared
Linux host. Reference-query executions fall by about 83% while
actual-query coverage is unchanged.
The existing differential test exercises the cached results and every
actual query configuration:
```shell
cargo test --profile ci -p datafusion --test extended_tests --features extended_tests null_aware_join_matches_reference
```
The full `./dev/rust_lint.sh` checks (including formatting and both
Clippy configurations) and the extended workspace suite passed after
rebasing onto current `main`. The RSS sampler fix from apache#26445 is now
included in `main`.
## Are there any user-facing changes?
None. This changes the test harness only.
AI-assisted contribution.1 parent 3284dc6 commit a616831
1 file changed
Lines changed: 23 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
| 34 | + | |
34 | 35 | | |
35 | 36 | | |
36 | 37 | | |
| |||
39 | 40 | | |
40 | 41 | | |
41 | 42 | | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
42 | 62 | | |
43 | 63 | | |
44 | 64 | | |
| |||
57 | 77 | | |
58 | 78 | | |
59 | 79 | | |
60 | | - | |
61 | | - | |
| 80 | + | |
| 81 | + | |
62 | 82 | | |
63 | | - | |
64 | 83 | | |
65 | | - | |
| 84 | + | |
66 | 85 | | |
67 | 86 | | |
68 | 87 | | |
| |||
0 commit comments