Closed
Conversation
The current regexp match in a route was checking for a comment
with single characters that compose the words "token", "splat",
and "megasplat". What we want is to match them *exactly*.
I'm assuming the brackets for character classes ("[]") were an
oversight.
Tests all still pass.
Member
I missed the '+' sign there. There's no reason for it since it
was for the character group brackets ("[]") which I just
removed.
Thanks, @veryrusty, for spotting it!
Member
|
👍 |
Member
xsawyerx
added a commit
that referenced
this pull request
Jan 12, 2016
[ BUG FIXES ]
* GH #1013, #1092: Remove race condition caused by caching available
engines. (Sawyer X, Menno Blom, Russell Jenkins)
* GH #1089: Exact macthing of route regex comments for tokens/splats.
(Sawyer X)
* GH #1079, #1082: Allow routes to return '0' as response content,
and serializer hooks are called when default response content is
to be returned. (Alberto Simões, Russell Jenkins)
* GH #1093, 1095: Use a dynamic TT2 INCLUDE_PATH to allow relative
views with relative includes; fixing regression introduced by #1037.
(Russell Jenkins)
* GH #1096, #1097: Return compatibility on Perl 5.8.x!
(Peter Mottram - @SysPete)
[ DOCUMENTATION ]
* GH #1076: Typo in Dancer2::Core::Hook POD. (Jonathan Scott Duff)
[ ENHANCEMENTS ]
* GH #1074: Add sample session engine config to skeleton app.
(Peter Mottram - @SysPete)
* GH #1088: Return route objects when defining new routes.
(Sawyer X)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current regexp match in a route was checking for a comment
with single characters that compose the words "token", "splat",
and "megasplat". What we want is to match them exactly.
I'm assuming the brackets for character classes ("[]") were an
oversight.
Tests all still pass.