Skip to content

Comments

Update backward compat for the -s option#1063

Closed
nunorc wants to merge 1 commit intoPerlDancer:masterfrom
nunorc:pr/cli-options
Closed

Update backward compat for the -s option#1063
nunorc wants to merge 1 commit intoPerlDancer:masterfrom
nunorc:pr/cli-options

Conversation

@nunorc
Copy link
Contributor

@nunorc nunorc commented Nov 16, 2015

Add the -s option to the backward compatibility conditional in dancer2 script, this should fix issue #1062 . Also add help for this option in the script man.

@hvoers
Copy link

hvoers commented Nov 16, 2015

Who needs the "backward compatibility'?

dancer2 is just a starter ...

@xsawyerx
Copy link
Member

It's not to maintain backwards compatibility, it's the backwards compatibility conditional. It's a layer that support compatibility, but seems to practically prevent support for something if it's not mentioned there too.

@xsawyerx
Copy link
Member

Merged, thanks! 👍

@xsawyerx xsawyerx closed this Dec 16, 2015
xsawyerx added a commit that referenced this pull request Dec 16, 2015
    [ DOCUMENTATION ]
    * Update core team members and contributors list. (Russell Jenkins)
    * GH #1066: Fix typo in Cookbook. (gertvanoss)
    * Correct typo. It's "query_parameters", not "request_parameters".
      Thanks to mst for letting me know and making sure I fix it!
      (Sawyer X)

    [ BUG FIXES ]
    * GH #1040: Forward with a post body no longer tries to re-read body
      filehandle. (Bas Bloemsaat)
    * GH #1042: Add Diggest::SHA as explicit prequisite for installs on
      perl < v5.9.3. (Russell Jenkins)
    * GH #1071, #1070: HTML escape the message in the default error page.
      (Peter Mottram)
    * GH #1062, #1063: Command line interface didn't support
      "-s SKELETON_DIRECTORY" in any order.
      (Nuno Carvalho)
    * GH #1052, #1053: Always call before_serializer hook when serializer
      is set.
      (Mickey Nasriachi)
    * GH #1034: Correctly use different session cookie name for Dancer2.
      (Jason A. Crome)
    * GH #1060: Remove trailing slashes when providing skeleton
      directory.
      (Gabor Szabo)

    [ ENHANCEMENTS ]
    * Use Plack 1.0035 to make sure you only have HTTP::Headers::Fast
      in the Plack::Request object internally.
    * GH #951 #1037: Dancer2::Template::TemplateToolkit no longer sets TT2
      INCLUDE_PATH directive, allowing `views` setting to be non-absolute
      paths. (Russell Jenkins)
    * GH #1032 #1043: Add .dancer file to new app scaffolding.
      (Jason A. Crome)
    * GH #1045: Small cleanups to Request class. (Russell Jenkins)
    * GH #1033: strict && warnings in Dancer2::CLI. (Mohammad S Anwar)
    * GH #1052, #1053: Allow before_serializer hook to change the content
      using @_.
      (Mickey Nasriachi)
    * GH #1060: Ignore .git directory when using an external skeleton
      directory.
      (Gabor Szabo)
    * GH #1060: Support more asset file extensions. (Gabor Szabo)
    * GH #1072: Add request->is_options(). (Theo van Hoesel)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants