Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting your PR, please review the following checklist:
[x ] CONSIDER adding a unit and/or fullscale test if your PR resolves an issue.
[x ] DO keep pull requests small so they can be easily reviewed.
[x ] DO make sure unit and fullscale tests pass.
[ x] DO make sure not to introduce any compiler warnings.
[x ] AVOID breaking the continuous integration build.
[ x] AVOID making significant changes to PeriLab's overall architecture.
test 3D aniso gives an error; not sure why. improves performance for the matrix based models