Skip to content

Clean up SSH error classification#4610

Merged
ilidemi merged 1 commit into
mainfrom
ssh-classification
Jul 22, 2026
Merged

Clean up SSH error classification#4610
ilidemi merged 1 commit into
mainfrom
ssh-classification

Conversation

@ilidemi

@ilidemi ilidemi commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Resolves DBI-927

  • SSH errors are notify connectivity by default
  • Except for the cases where we shot ourselves in the foot somehow by closing the connection and using it, those are RECOVERABLE as they're expected to only occur once
  • Remove the old raw ssh.OpenChannelError branch which was notify connectivity but got wrapped into our exceptions and handled above; make the client a field so the client isn't called directly without error wrapping

@ilidemi
ilidemi requested a review from a team as a code owner July 22, 2026 08:07
@claude

claude Bot commented Jul 22, 2026

Copy link
Copy Markdown

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

@ilidemi
ilidemi enabled auto-merge (squash) July 22, 2026 08:15
@ilidemi
ilidemi merged commit b09d58f into main Jul 22, 2026
20 checks passed
@ilidemi
ilidemi deleted the ssh-classification branch July 22, 2026 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants