Include rust builder in renovate, fix script on mac#4590
Merged
Conversation
ilidemi
commented
Jul 16, 2026
ilidemi
commented
Contributor
- Rust builder image has a custom naming scheme Renovate doesn't recognize. Not updating the image blocks rust upgrades (Lock file maintenance #4572)
- sed on mac doesn't support inline replacement so use a temp file for portability
- gitignore one more script output
Contributor
Renovate simulation reportOutput of Proposed updatesDependency updates in the resulting PRs:
|
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
pfcoperez
approved these changes
Jul 16, 2026
pfcoperez
reviewed
Jul 16, 2026
| function cleanup { | ||
| echo "Restoring renovate.json5 to point to the GitHub extension source" | ||
| sed -i 's/github>PeerDB-io/local>PeerDB-io/' renovate.json5 | ||
| sed 's/github>PeerDB-io/local>PeerDB-io/' renovate.json5 > renovate.json5.tmp && mv renovate.json5.tmp renovate.json5 |
Member
There was a problem hiding this comment.
According to this: https://stackoverflow.com/a/7573438
It can be simplified. I don't have a Mac to try it out though.
Member
There was a problem hiding this comment.
Suggested change
| sed 's/github>PeerDB-io/local>PeerDB-io/' renovate.json5 > renovate.json5.tmp && mv renovate.json5.tmp renovate.json5 | |
| sed -i.tmp 's/github>PeerDB-io/local>PeerDB-io/' renovate.json5 |
Contributor
Author
There was a problem hiding this comment.
Yeah this is shorter. Temp file still needs to be removed though with .tmp
ilidemi
enabled auto-merge (squash)
July 16, 2026 23:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.