Skip to content

fetch disk spill metrics for pg 14/15 as well#4575

Merged
jgao54 merged 1 commit into
mainfrom
pg-14-disk-spill
Jul 14, 2026
Merged

fetch disk spill metrics for pg 14/15 as well#4575
jgao54 merged 1 commit into
mainfrom
pg-14-disk-spill

Conversation

@jgao54

@jgao54 jgao54 commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

#3685 gated disk spill related metrics behind pg 16+, but they are available since pg 14, so make them available for older versions as well.

@jgao54
jgao54 requested a review from a team as a code owner July 13, 2026 20:25
@jgao54
jgao54 requested a review from ilidemi July 13, 2026 20:25
@claude

claude Bot commented Jul 13, 2026

Copy link
Copy Markdown

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

@codecov

codecov Bot commented Jul 13, 2026

Copy link
Copy Markdown

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
3045 2 3043 375
View the top 2 failed test(s) by shortest run time 
github.com/PeerDB-io/peerdb/flow/e2e::TestApiPg
Stack Traces | 0.02s run time 
=== RUN   TestApiPg
=== PAUSE TestApiPg
=== CONT  TestApiPg
--- FAIL: TestApiPg (0.02s)
2026/07/13 20:43:45 INFO Received AWS credentials from peer for connector: ci x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN}
2026/07/13 20:43:45 INFO Received AWS credentials from peer for connector: clickhouse x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN}
2026/07/13 20:43:45 INFO fetched schema x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} table=e2e_test_mach_udxr1wgp.test_nullable_sc_ch

github.com/PeerDB-io/peerdb/flow/e2e::TestApiPg/TestResyncWithSnapshotConfigDuringSnapshot
Stack Traces | 319s run time 
=== RUN   TestApiPg/TestResyncWithSnapshotConfigDuringSnapshot
=== PAUSE TestApiPg/TestResyncWithSnapshotConfigDuringSnapshot
=== CONT  TestApiPg/TestResyncWithSnapshotConfigDuringSnapshot
    api_test.go:1763: WaitFor wait for mirror to enter snapshot 2026-07-13 20:38:30.936084057 +0000 UTC m=+507.003699949
2026/07/13 20:38:30 INFO fetched schema x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} table=e2e_test_api_y1i4vcue.t1
    api_test.go:1763: UNEXPECTED TIMEOUT wait for mirror to enter snapshot 2026-07-13 20:43:31.280568012 +0000 UTC m=+807.348183904
    api_test.go:51: begin tearing down postgres schema api_9nuzcfdj
2026/07/13 20:43:31 INFO fetched schema x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} table=e2e_test_mach_oo6x3fm5.test_schema_as_column
--- FAIL: TestApiPg/TestResyncWithSnapshotConfigDuringSnapshot (318.78s)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

🔄 Flaky Test Detected

Analysis: TestApiPg/TestResyncWithSnapshotConfigDuringSnapshot hit a 5-minute WaitFor timeout waiting for the flow to reach the transient STATUS_SNAPSHOT state, yet the identical test passed in the two other matrix legs of the same commit — a resource-contention/timing flake, not a code bug.
Confidence: 0.85

✅ Automatically retrying the workflow

View workflow run

@jgao54
jgao54 merged commit ee09d79 into main Jul 14, 2026
21 of 22 checks passed
@jgao54
jgao54 deleted the pg-14-disk-spill branch July 14, 2026 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jeremyyang920 Jeremyyang920 Jeremyyang920 approved these changes
@ilidemi ilidemi Awaiting requested review from ilidemi

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jgao54 @Jeremyyang920