Pin go-mysql digest as well#4547
Merged
Merged
Conversation
ilidemi
enabled auto-merge (squash)
July 7, 2026 04:00
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
pfcoperez
reviewed
Jul 7, 2026
pfcoperez
left a comment
pfcoperez
left a comment
Member
There was a problem hiding this comment.
Pin LGTM,
Shouldn't we also include it at:
peerdb/flow/cmd/check_pinned_versions/main.go
Lines 19 to 22 in c2a2c33
?
pfcoperez
requested changes
Jul 7, 2026
pfcoperez
left a comment
pfcoperez
left a comment
Member
There was a problem hiding this comment.
Prior to the changes in this PR (main branch), a Renovate simulation:
LOG_LEVEL=debug npx renovate --platform=local --require-config=ignored --repository-cache=reset | sed '1,/packageFiles with updates/d' | sed 's/"config": {/{/' | sed '/DEBUG/,$d' | jq '.gomod[].deps[] | select(.depName == "github.com/go-mysql-org/go-mysql")' Still proposed the digest bump:
{
"datasource": "go",
"depType": "require",
"depName": "github.com/go-mysql-org/go-mysql",
"currentValue": "v1.15.1-0.20260701093637-35ca5c6ee8c8",
"currentDigest": "35ca5c6ee8c8",
"digestOneAndOnly": true,
"versioning": "loose",
"managerData": {
"multiLine": true,
"lineNumber": 37
},
"updates": [
{
"updateType": "digest",
"newValue": "v1.15.1-0.20260701093637-35ca5c6ee8c8",
"newDigest": "a57884f25cf0008867559df9012a6498bb17df70",
"branchName": "renovate/github.com-go-mysql-org-go-mysql-digest"
}
],
"packageName": "github.com/go-mysql-org/go-mysql",
"warnings": [],
"sourceUrl": "https://github.com/go-mysql-org/go-mysql",
"mostRecentTimestamp": "2026-05-06T12:41:30.000Z",
"currentVersion": "v1.15.1-0.20260701093637-35ca5c6ee8c8",
"fixedVersion": "v1.15.1-0.20260701093637-35ca5c6ee8c8"
}
{
"datasource": "go",
"depType": "require",
"depName": "github.com/go-mysql-org/go-mysql",
"currentValue": "v1.15.0",
"managerData": {
"multiLine": true,
"lineNumber": 11
},
"updates": [],
"packageName": "github.com/go-mysql-org/go-mysql",
"versioning": "semver",
"warnings": [],
"sourceUrl": "https://github.com/go-mysql-org/go-mysql",
"mostRecentTimestamp": "2026-05-06T12:41:30.000Z",
"currentVersion": "v1.15.0",
"currentVersionTimestamp": "2026-05-06T12:41:30.000Z",
"currentVersionAgeInDays": 61,
"fixedVersion": "v1.15.0"
}With these changes, the output is:
{
"datasource": "go",
"depType": "require",
"depName": "github.com/go-mysql-org/go-mysql",
"currentValue": "v1.15.1-0.20260701093637-35ca5c6ee8c8",
"currentDigest": "35ca5c6ee8c8",
"digestOneAndOnly": true,
"versioning": "loose",
"managerData": {
"multiLine": true,
"lineNumber": 37
},
"updates": [
{
"updateType": "digest",
"newValue": "v1.15.1-0.20260701093637-35ca5c6ee8c8",
"newDigest": "a57884f25cf0008867559df9012a6498bb17df70",
"branchName": "renovate/github.com-go-mysql-org-go-mysql-digest"
}
],
"packageName": "github.com/go-mysql-org/go-mysql",
"warnings": [],
"sourceUrl": "https://github.com/go-mysql-org/go-mysql",
"mostRecentTimestamp": "2026-05-06T12:41:30.000Z",
"currentVersion": "v1.15.1-0.20260701093637-35ca5c6ee8c8",
"fixedVersion": "v1.15.1-0.20260701093637-35ca5c6ee8c8"
}
{
"datasource": "go",
"depType": "require",
"depName": "github.com/go-mysql-org/go-mysql",
"currentValue": "v1.15.0",
"managerData": {
"multiLine": true,
"lineNumber": 11
},
"updates": [],
"packageName": "github.com/go-mysql-org/go-mysql",
"versioning": "semver",
"warnings": [],
"sourceUrl": "https://github.com/go-mysql-org/go-mysql",
"mostRecentTimestamp": "2026-05-06T12:41:30.000Z",
"currentVersion": "v1.15.0",
"currentVersionTimestamp": "2026-05-06T12:41:30.000Z",
"currentVersionAgeInDays": 61,
"fixedVersion": "v1.15.0"
}Which is identical so this PR is not taking the desired effect.
pfcoperez
approved these changes
Jul 7, 2026
pfcoperez
left a comment
pfcoperez
left a comment
Member
There was a problem hiding this comment.
In my previous test I was not loading the configuration properly and the selected JSON in the logs included disabled rules. Confirmed again:
➜ peerdb git:(renovate-no-mysql-digest) ✗ LOG_LEVEL=debug npx renovate --platform=local --require-config=optional --repository-cache=reset | grep 'flattened updates found' | tr ',' '\n' | grep mysql
github.com/go-mysql-org/go-mysql
➜ peerdb git:(renovate-no-mysql-digest) ✗ LOG_LEVEL=debug npx renovate --platform=local --require-config=optional --repository-cache=reset | grep 'flattened updates found' | tr ',' '\n' | grep mysql
These changes work, I wonder if you want to add the pin to the go checker but I am not blocking the PR.
pfcoperez
added a commit
that referenced
this pull request
Jul 14, 2026
Our dependencies updates come: - Mostly from Renovate through automatic updates. - When we want to remove a pinned version, through a manual PR removing the pin (less frequently with two remaining). We aim to not having pinned versions and if we do instruct Renovate to stop updating them. We also have some precedents of pinned packages that are just declared in Renovate: #4547 After this PR, will trust Renovate and go.mod as unique sources of truth for pins with tests as barriers. This also removes the not longer used deps updates skill.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go-mysql was pinned as we're using a pseudoversion from main and don't want to follow the rest of main. Turns out just version is not enough for renovate (#4546), adding digest as well