fix(mysql): classify event checksum error#4537
Merged
dtunikov merged 2 commits intoJul 7, 2026
Merged
Conversation
dtunikov
changed the title
dtunikov
commented
Jul 6, 2026
| } | ||
| } | ||
|
|
||
| if strings.Contains(err.Error(), replication.ErrChecksumMismatch.Error()) { |
Collaborator
Author
There was a problem hiding this comment.
kinda hard to emulate this one on e2e level
but this if statement should handle an error go-mysql returns (it wraps it with %v so we have to assert with string.Contains)
Contributor
There was a problem hiding this comment.
Can test with the debug image and
SET GLOBAL source_verify_checksum = 0;
SET GLOBAL debug = '+d,corrupt_read_log_event';
But yeah, no need for programmatic tests as we can trust go-mysql here
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
jgao54
approved these changes
Jul 6, 2026
ilidemi
approved these changes
Jul 7, 2026
| } | ||
| } | ||
|
|
||
| if strings.Contains(err.Error(), replication.ErrChecksumMismatch.Error()) { |
Contributor
There was a problem hiding this comment.
Can test with the debug image and
SET GLOBAL source_verify_checksum = 0;
SET GLOBAL debug = '+d,corrupt_read_log_event';
But yeah, no need for programmatic tests as we can trust go-mysql here
dtunikov
deleted the
fix/DBI-830/m1-binlog-crc32-checksums-stripped-but-never-verified
branch
July 7, 2026 06:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
verify event checksum and throw binlon invalid error if invalid