Skip to content

DBI-609: Add IAM auth support for CDC pipes with AWS Auruora'#4495

Merged
masterashu merged 3 commits into
mainfrom
dbi-609-add-iam-auth-support-for-aws-rdsaurora
Jul 2, 2026
Merged

DBI-609: Add IAM auth support for CDC pipes with AWS Auruora'#4495
masterashu merged 3 commits into
mainfrom
dbi-609-add-iam-auth-support-for-aws-rdsaurora

Conversation

@masterashu

@masterashu masterashu commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
2364 2 2362 227
View the top 2 failed test(s) by shortest run time 
github.com/PeerDB-io/peerdb/flow/e2e::TestApiMongo
Stack Traces | 0.01s run time 
=== RUN   TestApiMongo
=== PAUSE TestApiMongo
=== CONT  TestApiMongo
--- FAIL: TestApiMongo (0.01s)

github.com/PeerDB-io/peerdb/flow/e2e::TestApiMongo/TestEditTablesBeforeResync
Stack Traces | 0.07s run time 
=== RUN   TestApiMongo/TestEditTablesBeforeResync
=== PAUSE TestApiMongo/TestEditTablesBeforeResync
=== CONT  TestApiMongo/TestEditTablesBeforeResync
    api_test.go:2332: 
        	Error Trace:	.../flow/e2e/api_test.go:2332
        	Error:      	Received unexpected error:
        	            	rpc error: code = Internal desc = invalid mirror: rpc error: code = FailedPrecondition desc = failed to validate source connector mongo: oplog retention must be set to >= 24 hours, but got 23.000000
        	Test:       	TestApiMongo/TestEditTablesBeforeResync
    api_test.go:51: begin tearing down postgres schema api_tifzzqrx
--- FAIL: TestApiMongo/TestEditTablesBeforeResync (0.07s)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@github-actions

github-actions Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

🔄 Flaky Test Detected

Analysis: An unrelated Mongo oplog-retention validation tripped because the test container—explicitly started with --oplogMinRetentionHours 24—transiently reported 23 hours against a strict at-threshold check, an environmental flake unrelated to this AWS IAM-auth PR.
Confidence: 0.82

✅ Automatically retrying the workflow

View workflow run

@masterashu
masterashu force-pushed the dbi-609-add-iam-auth-support-for-aws-rdsaurora branch from f3a91c3 to fbac1e3 Compare June 29, 2026 15:13
@masterashu
masterashu marked this pull request as ready for review June 29, 2026 15:13
@masterashu
masterashu requested a review from a team as a code owner June 29, 2026 15:13
@claude

claude Bot commented Jun 29, 2026

Copy link
Copy Markdown

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

@Jeremyyang920

Jeremyyang920 commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Do we also need to update something for MySQL RDS/Auoura?

@masterashu

masterashu commented Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

Do we also need to update something for MySQL RDS/Auoura?

Not required, MySQL cdc was always supported using AWS IAM

@masterashu masterashu self-assigned this Jun 30, 2026
dtunikov
dtunikov reviewed Jun 30, 2026
View reviewed changes
Comment thread flow/connectors/utils/rds.go
dtunikov
dtunikov reviewed Jun 30, 2026
View reviewed changes
Comment thread flow/connectors/postgres/postgres_source.go
if c.rdsAuth != nil {
host := c.Config.Host
if c.Config.TlsHost != "" {
host = c.Config.TlsHost

@dtunikov dtunikov Jun 30, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, maybe we could pass RDSConnectionConfig into RDSAuth constructor (when it gets initialized in newPostgresConnector)? This RDSAuth anyways seems to be scoped to connector instance.
Then we wouldn't need to pass host/port/user in each method and duplicate things like if tlsHost != "" -> host = tlsHost (we already do it inside NewPostgresConnFromConfig).

@masterashu masterashu Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its was touching a lot of places so moved it into separate pr: #4526

pfcoperez
pfcoperez approved these changes Jun 30, 2026
View reviewed changes

@pfcoperez pfcoperez left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, do we want to add an input in PeerDB UI to set this too?

@masterashu

masterashu commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

LGTM, do we want to add an input in PeerDB UI to set this too?

Nothing in the peerdb ui which prevented us from creating the mirror, since in peerdb ui you create the peers separately.

@masterashu
masterashu merged commit 251ebc1 into main Jul 2, 2026
17 checks passed
@masterashu
masterashu deleted the dbi-609-add-iam-auth-support-for-aws-rdsaurora branch July 2, 2026 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dtunikov dtunikov dtunikov left review comments
@pfcoperez pfcoperez pfcoperez approved these changes

Assignees

@masterashu masterashu

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@masterashu @Jeremyyang920 @pfcoperez @dtunikov