Skip to content

[DBI-829] Extended GTID e2e and UTs#4493

Merged
pfcoperez merged 6 commits into
mainfrom
CP-829/mariadb/gtid/extended-tests
Jun 26, 2026
Merged

[DBI-829] Extended GTID e2e and UTs#4493
pfcoperez merged 6 commits into
mainfrom
CP-829/mariadb/gtid/extended-tests

Conversation

@pfcoperez

@pfcoperez pfcoperez commented Jun 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Member
  • Expanded unit tests for GTID decoding, including case description refactor.
  • Added e2e roundtrip gtid test.
  • Re-just test matrix in flow.yaml (left mariadb-pos in to test the failure of the newly added tests)

Follows: #4478
Closes: https://linear.app/clickhouse/issue/DBI-829

@codecov

codecov Bot commented Jun 24, 2026 •
edited
Loading

Copy link
Copy Markdown

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
2373 2 2371 204
View the top 2 failed test(s) by shortest run time 
github.com/PeerDB-io/peerdb/flow/e2e::TestGenericPG
Stack Traces | 0s run time 
=== RUN   TestGenericPG
=== PAUSE TestGenericPG
=== CONT  TestGenericPG
--- FAIL: TestGenericPG (0.00s)

github.com/PeerDB-io/peerdb/flow/e2e::TestGenericPG/Test_Inheritance_Table_With_Dynamic_Setting
Stack Traces | 61.4s run time 
=== RUN   TestGenericPG/Test_Inheritance_Table_With_Dynamic_Setting
=== PAUSE TestGenericPG/Test_Inheritance_Table_With_Dynamic_Setting
=== CONT  TestGenericPG/Test_Inheritance_Table_With_Dynamic_Setting
    generic_test.go:1101: UNEXPECTED STATUS TIMEOUT STATUS_SNAPSHOT
    postgres.go:92: begin tearing down postgres schema pg_msdyev6r
--- FAIL: TestGenericPG/Test_Inheritance_Table_With_Dynamic_Setting (61.37s)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@github-actions

github-actions Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

❌ Test Failure

Analysis: The new test TestMySQLGetMasterGTIDSet deterministically fails only on the maria-pos matrix config (other 3 configs pass) because it wrongly expects an error from GetMasterGTIDSet on MariaDB in position mode, indicating an incorrect test assumption rather than a flaky failure.
Confidence: 0.82

⚠️ This appears to be a real bug - manual intervention needed

View workflow run

@github-actions

github-actions Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

🔄 Flaky Test Detected

Analysis: The unrelated Postgres test TestGenericPG/Test_Inheritance_Table_With_Dynamic_Setting timed out waiting for the snapshot to reach RUNNING status (61s) due to high-concurrency resource contention (statement timeouts in Postgres logs), while the other two matrix shards—including the PR's actual maria-gtid target—passed.
Confidence: 0.9

✅ Automatically retrying the workflow

View workflow run

@pfcoperez

pfcoperez commented Jun 25, 2026

Copy link
Copy Markdown
Member Author

QA Validation

I intentionally left maria-pos test matrix entry in a first iteration of this PR obtain a negative run for TestMySQLGetMasterGTIDSet using a maria-pos source: https://github.com/PeerDB-io/peerdb/actions/runs/28127684482/job/83295605875

It did fail as expected.

@pfcoperez
pfcoperez marked this pull request as ready for review June 25, 2026 06:17
@pfcoperez
pfcoperez requested a review from a team as a code owner June 25, 2026 06:17
@claude

claude Bot commented Jun 25, 2026

Copy link
Copy Markdown

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

@pfcoperez
pfcoperez force-pushed the CP-829/mariadb/gtid/extended-tests branch from 94a135d to 5117f08 Compare June 25, 2026 08:06
@pfcoperez pfcoperez changed the title [CP-829] Extended GTID e2e and UTs [DBI-829] Extended GTID e2e and UTs Jun 25, 2026
ilidemi
ilidemi approved these changes Jun 26, 2026
View reviewed changes

@ilidemi ilidemi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I now realize where my previous confusion came from. 829 should've been split into two tasks, GTID parsing and adding newer Maria to CI. It's the newer Maria that unblocks other tasks, that are related to handling its features.

Comment thread .github/workflows/flow.yml
db-version: [
{pg: 16, mysql: 'mysql-gtid', mongo: '6.0', ch: 'lts'},
{pg: 17, mysql: 'mysql-pos', mongo: '7.0', ch: 'stable'},
{pg: 18, mysql: 'maria-pos', mongo: '8.0', ch: 'latest'},

@ilidemi ilidemi Jun 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's one more place with maria-pos (moved in #4452)

Comment thread flow/connectors/mysql/gtid_test.go
@pfcoperez
pfcoperez force-pushed the CP-829/mariadb/gtid/extended-tests branch from dfc4d02 to dbc708a Compare June 26, 2026 12:30
@pfcoperez
pfcoperez merged commit 56e27cc into main Jun 26, 2026
17 checks passed
@pfcoperez
pfcoperez deleted the CP-829/mariadb/gtid/extended-tests branch June 26, 2026 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ilidemi ilidemi ilidemi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pfcoperez @ilidemi