Conversation
What resources are used and what test are run are given as input parameters.
Code review1 issue found. Checked for bugs and CLAUDE.md compliance. Bug: TILT_VERSION env var is defined but never used (line 45 / line 102) TILT_VERSION: 0.37.0 is set as an env var with the comment Pin Tilt for reproducible runs, but the Install Tilt step runs: curl -fsSL https://raw.githubusercontent.com/tilt-dev/tilt/master/scripts/install.sh | bash The Tilt install script reads the VERSION env var (not TILT_VERSION) to determine which version to install. Since TILT_VERSION is never passed to the script, every CI run installs the latest Tilt release instead of 0.37.0. Suggested fix: curl -fsSL ... | VERSION=$TILT_VERSION bash See lines: peerdb/.github/workflows/tilt-flow.yml Lines 44 to 46 in 21f1deb peerdb/.github/workflows/tilt-flow.yml Lines 101 to 103 in 21f1deb |
Follows #4474, With these changes, Tilt environment on CI is fully functional. We also move to use e2e invocation directly with `gotestsum`. Additionally, internal test results ingestion is moved to an action and shared between traditional flow.yml based and Tilt based CI. Finally, this workflow is set-up so it can be invoked from other workflows as follow: ```yaml jobs: pg-ch-e2e: uses: ./.github/workflows/tilt-flow.yml with: test_matcher: TestGenericCH_PG ancillary_services: postgres clickhouse secrets: inherit ```
2 participants
What resources are used and what test are run are given as input parameters.
📝 This is an experiment to use Tilt in CI workflows.