Classify mid-CDC SSH tunnel failures as connectivity errors#4443
Merged
Conversation
When an SSH tunnel's keepalive fails, the Postgres connector proactively closes the replication connection, which surfaces in the CDC loop as a generic ReceiveMessage error. Depending on the underlying type it could fall through to the unclassified OTHER bucket and page us, even though tunnel failures are retriable and almost always customer-side. Tag the error with a new SSHTunnelConnectionError when the tunnel is bad, and classify it as NOTIFY_CONNECTIVITY (notify user, no page). Also make SSHTunnel.badTunnel atomic since it is now read from the CDC loop. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
ilidemi
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When an SSH tunnel's keepalive fails mid-CDC, the Postgres connector proactively closes the replication connection. That surfaces in the CDC loop as a generic
ReceiveMessage failederror which — depending on the underlying type — could fall through to the unclassifiedOTHERbucket (NotifyTelemetry) and page us, even though tunnel failures are retriable and almost always customer-side.SSH setup failures were already classified as
NOTIFY_CONNECTIVITY; this closes the gap for failures that happen during CDC while the tunnel is open.Changes
SSHTunnelConnectionErrorexception type.PullCdcRecordswraps the read error in it whenp.ssh.IsBad().NOTIFY_CONNECTIVITY(notify user, no page), placed before the genericnet.*matchers so the tunnel context isn't lost.SSHTunnel.badTunnelis nowatomic.Bool(read from the CDC loop) + nil-safeIsBad()accessor.🤖 Generated with Claude Code