Make PG SkipCertVerification take effect in PG-PG PGdump#4395
Merged
Conversation
…o vreify CA level
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Amogh-Bharadwaj
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Default to vreify CA level.
On the one hand, In #4388 aligned PG peers TLS configuration with other connectors, adding an overlapping configuration parameters
disable_tlsandskip_cert_verification:peerdb/protos/peers.proto
Lines 131 to 132 in b31f943
On the other hand, PG to PG pipes uses direct schema dump to reproduce source entities in target PG. The mentioned change made it use
disable_tlsbut it didn't introduce readingskip_cert_verification. This was intentional because this changes makes the default more strict for PG schema dump process.This PR brings "default to verify host" to the PG dump process in an isolated way to be reviewed separately.