Skip to content

Use the latest clickhouse-go/[email protected] and [email protected]#3886

Merged
jgao54 merged 2 commits intomainfrom
upgrade-clickhouse-go
Feb 4, 2026
Merged

Use the latest clickhouse-go/[email protected] and [email protected]#3886
jgao54 merged 2 commits intomainfrom
upgrade-clickhouse-go

Conversation

@jgao54
Copy link
Copy Markdown
Contributor

@jgao54 jgao54 commented Feb 3, 2026

Bug-fix has been made upstream to return the correct ScanType so we can remove this workaround.

Waiting to see if we could also get the other fix in on precision as well.
Looks like both changes are in (clickhouse-go & ch-go).

@jgao54 jgao54 force-pushed the upgrade-clickhouse-go branch from a5e7d0d to b7fefe9 Compare February 3, 2026 21:12
@jgao54 jgao54 force-pushed the upgrade-clickhouse-go branch from b7fefe9 to df9ba92 Compare February 3, 2026 21:17
@jgao54 jgao54 changed the title [WIP] Use the latest clickhouse-go/[email protected] Use the latest clickhouse-go/[email protected] Feb 3, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 3, 2026

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
1654 2 1652 146
View the top 2 failed test(s) by shortest run time
github.com/PeerDB-io/peerdb/flow/e2e::TestPeerFlowE2ETestSuitePG_CH_Cluster
Stack Traces | 0.01s run time
=== RUN   TestPeerFlowE2ETestSuitePG_CH_Cluster
=== PAUSE TestPeerFlowE2ETestSuitePG_CH_Cluster
=== CONT  TestPeerFlowE2ETestSuitePG_CH_Cluster
--- FAIL: TestPeerFlowE2ETestSuitePG_CH_Cluster (0.01s)
2026/02/03 21:43:09 INFO Received AWS credentials from peer for connector: ci x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN}
2026/02/03 21:43:09 INFO Received AWS credentials from peer for connector: clickhouse x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN}
2026/02/03 21:43:09 INFO fetched schema x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} table=e2e_test_mychcl_3m65foiv.test_blobs
github.com/PeerDB-io/peerdb/flow/e2e::TestPeerFlowE2ETestSuitePG_CH_Cluster/Test_Unbounded_Numeric_With_FF
Stack Traces | 5.09s run time
=== RUN   TestPeerFlowE2ETestSuitePG_CH_Cluster/Test_Unbounded_Numeric_With_FF
=== PAUSE TestPeerFlowE2ETestSuitePG_CH_Cluster/Test_Unbounded_Numeric_With_FF
=== CONT  TestPeerFlowE2ETestSuitePG_CH_Cluster/Test_Unbounded_Numeric_With_FF
2026/02/03 21:41:43 INFO [pg_query_executor] committed transaction for query x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart query="SELECT id,\"key\" FROM e2e_test_pgchcl_2woronhl.\"test_nullengine\" ORDER BY id" rows=3 bytes=26 channelLen=0
    clickhouse_test.go:751: Failed to connect temporal client: failed reaching server: context deadline exceeded
    clickhouse.go:114: begin tearing down postgres schema pgchcl_t079fgbp
--- FAIL: TestPeerFlowE2ETestSuitePG_CH_Cluster/Test_Unbounded_Numeric_With_FF (5.09s)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@jgao54 jgao54 marked this pull request as ready for review February 3, 2026 22:15
@jgao54 jgao54 requested review from ilidemi and masterashu February 3, 2026 22:15
@jgao54 jgao54 enabled auto-merge (squash) February 3, 2026 22:16
@jgao54 jgao54 changed the title Use the latest clickhouse-go/[email protected] Use the latest clickhouse-go/[email protected] and [email protected] Feb 3, 2026
@jgao54 jgao54 merged commit 6be2b08 into main Feb 4, 2026
15 of 16 checks passed
@jgao54 jgao54 deleted the upgrade-clickhouse-go branch February 4, 2026 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants