feat(classifier): add ACCESS_ENTITY_NOT_FOUND with condition as recoverable#2833
Merged
iamKunalGupta merged 2 commits intomainfrom Apr 10, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2833 +/- ##
==========================================
+ Coverage 51.78% 51.84% +0.06%
==========================================
Files 184 184
Lines 27864 27868 +4
==========================================
+ Hits 14428 14447 +19
+ Misses 11786 11775 -11
+ Partials 1650 1646 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
serprex
approved these changes
Apr 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When droppping a pipe during initial load it can take some time for the workflow to get cancelled. During this time the insert queries fail with errros like:
ID(a14c2a1c-edcd-5fcb-73be-bd04e09fccb7) not found in user directories.For now classifying as recoverable because if seen for a longer duration we should be alerted
ref ClickHouse/ch-go#1058 for adding the new error code