Skip to content

Fix data.remote R check binding notes - #4013

Merged
infotroph merged 2 commits into
PecanProject:developfrom
AMBRA7592:GH-2758-data-remote-rcheck-bindings
Jun 2, 2026
Merged

infotroph merged 2 commits into
PecanProject:developfrom
AMBRA7592:GH-2758-data-remote-rcheck-bindings

Conversation

@AMBRA7592

@AMBRA7592 AMBRA7592 commented May 27, 2026 •

Copy link
Copy Markdown
Contributor

Description

Addresses part of #2758 by cleaning up PEcAn.data.remote R check binding notes. Per review feedback, this removes the unused grid2netcdf() helper rather than trying to repair it.

  • Removes unused grid2netcdf() and its generated Rd file.
  • Keeps the cleaner foreach zip loop in download.LandTrendr.AGB().
  • Updates CHANGELOG.md, modules/data.remote/NEWS.md, and the modules.data.remote reference check log.

Motivation and Context

This reduces the R CMD check notes tracked in #2758 for the PEcAn.data.remote package.

Fixes part of #2758.

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

Checklist:

  • My change requires a change to the documentation.
  • My name is in the list of CITATION.cff
  • I agree that PEcAn Project may distribute my contribution under any or all of
    • the same license as the existing code,
    • and/or the BSD 3-clause license.
  • I have updated the CHANGELOG.md.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Validation

  • git diff --check
  • Parsed the edited R files with Rscript
  • Ran a targeted codetools usage check for download.LandTrendr.AGB()

R CMD check --no-manual --no-build-vignettes modules/data.remote was attempted locally, but could not complete because this fresh environment is missing the package dependency stack (curl, DBI, ncdf4, PEcAn.*, etc.).

Comment thread modules/data.remote/R/regrid.R Resolved
@infotroph

Copy link
Copy Markdown
Member

R CMD check [...] was attempted locally, but [...] missing the package dependency stack

Please follow the [installation steps](](https://github.com/pecanProject/pecan/#installation) listed in the project README to get a working local development environment. Once that's working, you should be able to simply run make check to verify your changes had the intended effect on check output.

Comment thread modules/data.remote/R/LandTrendr.AGB.R Resolved
@AMBRA7592
AMBRA7592 force-pushed the GH-2758-data-remote-rcheck-bindings branch from ea56b31 to d3f0600 Compare May 27, 2026 19:13
@AMBRA7592

Copy link
Copy Markdown
Contributor Author

Thanks, updated in d3f0600. I removed grid2netcdf() and its generated Rd file rather than patching it, and kept the download.LandTrendr.AGB() cleanup/reference-log update.

Comment thread modules/data.remote/NEWS.md Resolved
@infotroph
infotroph enabled auto-merge June 2, 2026 07:09
@infotroph
infotroph added this pull request to the merge queue Jun 2, 2026
Merged via the queue into PecanProject:develop with commit 7964f6c Jun 2, 2026
19 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants