Repository navigation
fix: keep numeric filter arguments as long through bounds checks - #842
Merged
ebussieres merged 1 commit intoOct 19, 2026
Merged
ebussieres merged 1 commit into
ebussieres merged 1 commit into
Conversation
split, abbreviate and slice narrowed their Long arguments with intValue() before validating, so values beyond the int range wrapped to unrelated numbers: split could leave the input unsplit, abbreviate could truncate a short string, and slice could return the wrong substring instead of failing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #841.
split,abbreviateandsliceread numeric arguments asLongbut narrowed them withintValue()before the bounds checks, so values beyond the int range wrapped:splitclamps the limit to the int range, so a huge limit still means "all the parts"abbreviatecompareslengthaslong, so a huge width returns the input unchanged and a wrapped negative is no longer possibleslicekeepsfromIndex/toIndexaslongthrough the checks and now also validatesfromIndexagainst the input size whentoIndexis omitted (previously a rawStringIndexOutOfBoundsExceptionescaped)Regression tests cover one failing case per filter;
SplitFilterTestandCoreFiltersTestpass 103/103.I audited every
intValue()call in the codebase for the same pattern. These three filters were the only real bugs:SplitFilter,AbbreviateFilter,SliceFilterOperatorUtilsinteger pathlongOperationfirstTypeUtils.compatibleCastintMapResolverkey castIntegerkey typeMapExpressioncapacity hintMap.size()is already intLazyLength/LazyRevIndexSpecializedWriterIntegercast first