Merge dashpay#6444: fix: add platform transfer to "most common" filter

PastaPastaPasta · PastaPastaPasta · commit c074e0965b0a · 2024-12-03T08:38:18.000-06:00
36893e4 fix: add platform transfer to "most common" filter on transactions tab (Konstantin Akimov) d033a3a refactor: change mask from Dec presentation to Hex for transaction filter (Konstantin Akimov) Pull request description: ## Issue being fixed or feature implemented Follow-up dashpay#6131 - missing 'Platform Transfer' in the list of most common. Reported by splawik. ## What was done? Updated filter, added comment to prevent similar mistakes in future, present filter in hex for better readability. ## How Has This Been Tested? Transaction with platform transfer appeared in filter "Most Common" ![image](https://github.com/user-attachments/assets/ccc17553-d71a-45f8-be2f-8ce5fb699c1a) Also they are added to Overview page (compare screenshots by 'address' field) ![image](https://github.com/user-attachments/assets/ea657672-46c8-4a66-a972-15768feb4d57) ## Breaking Changes N/A ## Checklist: - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone ACKs for top commit: UdjinM6: utACK 36893e4 PastaPastaPasta: utACK 36893e4 Tree-SHA512: e072b78e257b2c262a912a3cc0daebde93aca655edfee9bbf4869f2528f10377d7d234c73c4fd7ab6006e87607d5a7c4eddd7634d55b16d1b3885d0bc48f225a
diff --git a/src/qt/transactionfilterproxy.h b/src/qt/transactionfilterproxy.h
@@ -23,7 +23,7 @@ class TransactionFilterProxy : public QSortFilterProxyModel
     /** Type filter bit field (all types) */
     static const quint32 ALL_TYPES = 0xFFFFFFFF;
     /** Type filter bit field (all types but Darksend-SPAM) */
-    static const quint32 COMMON_TYPES = 4223;
+    static const quint32 COMMON_TYPES = 0x307f;
 
     static quint32 TYPE(int type) { return 1<<type; }
 
diff --git a/src/qt/transactionrecord.h b/src/qt/transactionrecord.h
@@ -82,6 +82,7 @@ class TransactionStatus
 class TransactionRecord
 {
 public:
+    // Update COMMON_TYPES in TransactionFilterProxyWhen when adding a new type
     enum Type
     {
         Other,

Original file line number	Diff line number	Diff line change
`@@ -82,6 +82,7 @@ class TransactionStatus`
`82`	`82`	`class TransactionRecord`
`83`	`83`	`{`
`84`	`84`	`public:`
	`85`	`+ // Update COMMON_TYPES in TransactionFilterProxyWhen when adding a new type`
`85`	`86`	`enum Type`
`86`	`87`	`{`
`87`	`88`	`Other,`