qt: Don't log to console by default

laanwj · laanwj · commit aee80b0ef9f9 · 2018-04-23T09:25:34.000+02:00
Default `-printtoconsole` to false for the GUI. GUI programs should not
print to the console unnecessarily. For example, when launched by the
window manager, the output might end up in the X session log file,
resulting in duplicate logging. On Windows, it is pointless as well
because bitcoin-qt isn't a console application.
diff --git a/src/qt/bitcoin.cpp b/src/qt/bitcoin.cpp
@@ -403,6 +403,10 @@ void BitcoinApplication::startThread()
 
 void BitcoinApplication::parameterSetup()
 {
+    // Default printtoconsole to false for the GUI. GUI programs should not
+    // print to the console unnecessarily.
+    gArgs.SoftSetBoolArg("-printtoconsole", false);
+
     m_node.initLogging();
     m_node.initParameterInteraction();
 }

Original file line number	Diff line number	Diff line change
`@@ -403,6 +403,10 @@ void BitcoinApplication::startThread()`
`403`	`403`
`404`	`404`	`void BitcoinApplication::parameterSetup()`
`405`	`405`	`{`
	`406`	`+ // Default printtoconsole to false for the GUI. GUI programs should not`
	`407`	`+ // print to the console unnecessarily.`
	`408`	`+ gArgs.SoftSetBoolArg("-printtoconsole", false);`
	`409`	`+`
`406`	`410`	`m_node.initLogging();`
`407`	`411`	`m_node.initParameterInteraction();`
`408`	`412`	`}`