Increase signal to noise in appveyor build output by reducing the MSVC warning count from 12 to 4 (12 is assuming the changes in bitcoin#14086 are also implemented).

practicalswift · practicalswift · commit 8ecaee13f70a · 2018-09-03T19:53:56.000+02:00
This makes it easier to spot errors or more important warnings in the verbose appveyor output. See bitcoin#14086 (comment) plus discussion for context.
diff --git a/src/rest.cpp b/src/rest.cpp
@@ -464,7 +464,7 @@ static bool rest_getutxos(HTTPRequest* req, const std::string& strURIPart)
                 oss >> fCheckMemPool;
                 oss >> vOutPoints;
             }
-        } catch (const std::ios_base::failure& e) {
+        } catch (const std::ios_base::failure&) {
             // abort in case of unreadable binary data
             return RESTERR(req, HTTP_BAD_REQUEST, "Parse error");
         }
diff --git a/src/test/coins_tests.cpp b/src/test/coins_tests.cpp
@@ -508,7 +508,7 @@ BOOST_AUTO_TEST_CASE(ccoins_serialization)
         Coin cc4;
         ss4 >> cc4;
         BOOST_CHECK_MESSAGE(false, "We should have thrown");
-    } catch (const std::ios_base::failure& e) {
+    } catch (const std::ios_base::failure&) {
     }
 
     // Very large scriptPubKey (3*10^9 bytes) past the end of the stream
@@ -521,7 +521,7 @@ BOOST_AUTO_TEST_CASE(ccoins_serialization)
         Coin cc5;
         ss5 >> cc5;
         BOOST_CHECK_MESSAGE(false, "We should have thrown");
-    } catch (const std::ios_base::failure& e) {
+    } catch (const std::ios_base::failure&) {
     }
 }
 
@@ -719,7 +719,7 @@ static void CheckAddCoinBase(CAmount base_value, CAmount cache_value, CAmount mo
         test.cache.AddCoin(OUTPOINT, Coin(std::move(output), 1, coinbase), coinbase);
         test.cache.SelfTest();
         GetCoinsMapEntry(test.cache.map(), result_value, result_flags);
-    } catch (std::logic_error& e) {
+    } catch (std::logic_error&) {
         result_value = FAIL;
         result_flags = NO_ENTRY;
     }
@@ -780,7 +780,7 @@ void CheckWriteCoins(CAmount parent_value, CAmount child_value, CAmount expected
         WriteCoinsViewEntry(test.cache, child_value, child_flags);
         test.cache.SelfTest();
         GetCoinsMapEntry(test.cache.map(), result_value, result_flags);
-    } catch (std::logic_error& e) {
+    } catch (std::logic_error&) {
         result_value = FAIL;
         result_flags = NO_ENTRY;
     }
diff --git a/src/test/dbwrapper_tests.cpp b/src/test/dbwrapper_tests.cpp
@@ -262,7 +262,7 @@ struct StringContentsSerializer {
                 try {
                     READWRITE(c);
                     str.push_back(c);
-                } catch (const std::ios_base::failure& e) {
+                } catch (const std::ios_base::failure&) {
                     break;
                 }
             }
diff --git a/src/test/net_tests.cpp b/src/test/net_tests.cpp
@@ -115,7 +115,7 @@ BOOST_AUTO_TEST_CASE(caddrdb_read)
         unsigned char pchMsgTmp[4];
         ssPeers1 >> pchMsgTmp;
         ssPeers1 >> addrman1;
-    } catch (const std::exception& e) {
+    } catch (const std::exception&) {
         exceptionThrown = true;
     }
 
@@ -148,7 +148,7 @@ BOOST_AUTO_TEST_CASE(caddrdb_read_corrupted)
         unsigned char pchMsgTmp[4];
         ssPeers1 >> pchMsgTmp;
         ssPeers1 >> addrman1;
-    } catch (const std::exception& e) {
+    } catch (const std::exception&) {
         exceptionThrown = true;
     }
     // Even through de-serialization failed addrman is not left in a clean state.
diff --git a/src/wallet/rpcwallet.cpp b/src/wallet/rpcwallet.cpp
@@ -288,7 +288,6 @@ static UniValue setlabel(const JSONRPCRequest& request)
         throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, "Invalid Bitcoin address");
     }
 
-    std::string old_label = pwallet->mapAddressBook[dest].name;
     std::string label = LabelFromValue(request.params[1]);
 
     if (IsMine(*pwallet, dest)) {

Original file line number	Diff line number	Diff line change
`@@ -464,7 +464,7 @@ static bool rest_getutxos(HTTPRequest* req, const std::string& strURIPart)`
`464`	`464`	`oss >> fCheckMemPool;`
`465`	`465`	`oss >> vOutPoints;`
`466`	`466`	`}`
`467`		`- } catch (const std::ios_base::failure& e) {`
	`467`	`+ } catch (const std::ios_base::failure&) {`
`468`	`468`	`// abort in case of unreadable binary data`
`469`	`469`	`return RESTERR(req, HTTP_BAD_REQUEST, "Parse error");`
`470`	`470`	`}`
Original file line number	Diff line number	Diff line change
`@@ -262,7 +262,7 @@ struct StringContentsSerializer {`
`262`	`262`	`try {`
`263`	`263`	`READWRITE(c);`
`264`	`264`	`str.push_back(c);`
`265`		`- } catch (const std::ios_base::failure& e) {`
	`265`	`+ } catch (const std::ios_base::failure&) {`
`266`	`266`	`break;`
`267`	`267`	`}`
`268`	`268`	`}`
Original file line number	Diff line number	Diff line change
`@@ -288,7 +288,6 @@ static UniValue setlabel(const JSONRPCRequest& request)`
`288`	`288`	`throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, "Invalid Bitcoin address");`
`289`	`289`	`}`
`290`	`290`
`291`		`- std::string old_label = pwallet->mapAddressBook[dest].name;`
`292`	`291`	`std::string label = LabelFromValue(request.params[1]);`
`293`	`292`
`294`	`293`	`if (IsMine(*pwallet, dest)) {`